8372324: jdk/jfr/event/gc/detailed/TestStringDeduplicationEvent.java#Parallel failed

[fandreuz]

The assertion is used to validate a precondition for the test. As long as the deduplication happens inside the RecordingStream scope, a StringDeduplication event will be recorded. Thus the assertion is not needed and can be removed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372324: jdk/jfr/event/gc/detailed/TestStringDeduplicationEvent.java#Parallel failed (Bug - P4)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer) Review applies to bd6d8ff5
• Albert Mingkun Yang (@albertnetymk - Reviewer) Review applies to bd6d8ff5
• Erik Gahlin (@egahlin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28467/head:pull/28467
$ git checkout pull/28467

Update a local copy of the PR:
$ git checkout pull/28467
$ git pull https://git.openjdk.org/jdk.git pull/28467/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28467

View PR using the GUI difftool:
$ git pr show -t 28467

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28467.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fandreuzzi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fandreuz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372324: jdk/jfr/event/gc/detailed/TestStringDeduplicationEvent.java#Parallel failed

Reviewed-by: egahlin, mbaesken, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• b36b694: 8371259: ML-DSA AVX2 and AVX512 intrinsics and improvements
• c0abecd: 8372441: JFR: Improve logging of TestBackToBackSensitive
• c123006: 8363943: ARM32: Represent Registers as values
• ... and 34 more: https://git.openjdk.org/jdk/compare/ee9d553e51c01529495b8ca34b296b6e684e905d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken, @albertnetymk, @egahlin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@fandreuz The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7c3a2e89)
• 00: Full (bd6d8ff5)

[MBaesken]

If you prefer, I can test your PR for some days in our CI to check for further issues.

[fandreuz]

If you prefer, I can test your PR for some days in our CI to check for further issues.

That would be great, thanks!

[fandreuz]

/issue JDK-8372324

[openjdk]

@fandreuz This issue is referenced in the PR title - it will now be updated.

[MBaesken]

No new issues so far, I think you can go ahead and integrate !

[fandreuz]

Thank you for the review @MBaesken and @albertnetymk !

[fandreuz]

/integrate

[openjdk]

@fandreuz
Your change (at version bd6d8ff) is now ready to be sponsored by a Committer.

[egahlin]

Looks like getValue() is never used. Can it be removed, and the reflection code? Do we really need the fields to be volatile?

[fandreuz]

Looks like getValue() is never used. Can it be removed, and the reflection code?

Thanks, it can be removed indeed.

Do we really need the fields to be volatile?

My reasoning there is that the strings I create should be used somehow to make sure no unpredictable optimizations tamper with the test.

[egahlin]

My reasoning there is that the strings I create should be used somehow to make sure no unpredictable optimizations tamper with the test.

We have made fields public in other JFR tests, but volatile works as well.

[egahlin]

I can sponsor this.

[fandreuz]

/integrate

[openjdk]

@fandreuz
Your change (at version 7c3a2e8) is now ready to be sponsored by a Committer.

[egahlin]

/sponsor

[openjdk]

Going to push as commit d9b6c31.
Since your change was applied there have been 37 commits pushed to the master branch:

• b36b694: 8371259: ML-DSA AVX2 and AVX512 intrinsics and improvements
• c0abecd: 8372441: JFR: Improve logging of TestBackToBackSensitive
• c123006: 8363943: ARM32: Represent Registers as values
• ... and 34 more: https://git.openjdk.org/jdk/compare/ee9d553e51c01529495b8ca34b296b6e684e905d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin @fandreuz Pushed as commit d9b6c31.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.