8370887: DelayScheduler.replace method may break the 4-ary heap in certain scenarios

[AlanBateman]

DelayScheduler.replace missing check to sift up when replaced with smaller value. checkHeap checks invariants when replacing. Executing tests with make run-test or other targets runs tests with -esa so assume is enabled.

New regression test to ensure delayed tests executes in expected delay order.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8370887: DelayScheduler.replace method may break the 4-ary heap in certain scenarios (Bug - P4)

Reviewers

• Viktor Klang (@viktorklang-ora - Reviewer)

Contributors

• Doug Lea <[email protected]>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28469/head:pull/28469
$ git checkout pull/28469

Update a local copy of the PR:
$ git checkout pull/28469
$ git pull https://git.openjdk.org/jdk.git pull/28469/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28469

View PR using the GUI difftool:
$ git pr show -t 28469

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28469.diff

Using Webrev

Link to Webrev Comment

[AlanBateman]

/contributor add dl

[bridgekeeper]

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370887: DelayScheduler.replace method may break the 4-ary heap in certain scenarios

Co-authored-by: Doug Lea <[email protected]>
Reviewed-by: vklang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• aec5472: 8372159: HttpClient SelectorManager thread could be a VirtualThread
• 0a963b6: 8371701: Add ability to set NUMA-affinity for threads
• 8ae4ea8: 8371262: sun/security/pkcs11/Cipher/KeyWrap tests may silently skip
• ... and 8 more: https://git.openjdk.org/jdk/compare/ee9d553e51c01529495b8ca34b296b6e684e905d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@AlanBateman
Contributor Doug Lea <[email protected]> successfully added.

[openjdk]

@AlanBateman The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ea058223)

[viktorklang-ora]

Nice work @AlanBateman & @DougLea 👍

[AlanBateman]

/integrate

[openjdk]

Going to push as commit cc5b35b.
Since your change was applied there have been 21 commits pushed to the master branch:

• dea95e6: 8371869: RISC-V: too many warnings when build on BPI-F3 SBC
• 42b108b: 8372155: ReleaseInfoPlugin doesn't handle input file as UTF-8 properly
• e00dec5: 8371667: Shenandoah: Re-design alloc request type enum for better efficiency and cleaner code
• ... and 18 more: https://git.openjdk.org/jdk/compare/ee9d553e51c01529495b8ca34b296b6e684e905d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@AlanBateman Pushed as commit cc5b35b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.