-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8372384: Remove unused local variable in MacroAssembler::sha512_update_sha_state on PPC #28472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8372384: Remove unused local variable in MacroAssembler::sha512_update_sha_state on PPC #28472
Conversation
…e_sha_state on PPC
|
Hi @wb-ly878512, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user wb-ly878512" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
❗ This change is not yet ready to be integrated. |
|
@wb-ly878512 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
The contribution is made on behalf of Alibaba. |
|
/covered |
|
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
TheRealMDoerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
Issue
https://bugs.openjdk.org/browse/JDK-8372384
Summary
Remove an unused local variable from the PowerPC SHA-512 macro assembler implementation.
Problem
MacroAssembler::sha512_update_sha_stateinmacroAssembler_ppc_sha.cppdefines a local constant:static const int total_inis = sizeof(inis)/sizeof(VectorRegister);
which is never used. This triggers static analysis warnings (e.g. “unused variable” / “dead code”) and slightly reduces code clarity, although it has no impact on correctness or runtime behavior.
The rest of the function relies only on
total_hsand the implicit relation betweenhsandinis. The unusedtotal_inisappears to be left over from an earlier version of the code or a refactoring.Solution
Remove the unused local variable
total_inisand keep the existing logic unchanged.Testing
Trivial change. No additional testing.
Progress
Error
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28472/head:pull/28472$ git checkout pull/28472Update a local copy of the PR:
$ git checkout pull/28472$ git pull https://git.openjdk.org/jdk.git pull/28472/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28472View PR using the GUI difftool:
$ git pr show -t 28472Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28472.diff