Skip to content

Conversation

@wb-ly878512
Copy link

@wb-ly878512 wb-ly878512 commented Nov 24, 2025

Issue

https://bugs.openjdk.org/browse/JDK-8372384
Summary

Remove an unused local variable from the PowerPC SHA-512 macro assembler implementation.
Problem

MacroAssembler::sha512_update_sha_state in macroAssembler_ppc_sha.cpp defines a local constant:
static const int total_inis = sizeof(inis)/sizeof(VectorRegister);
which is never used. This triggers static analysis warnings (e.g. “unused variable” / “dead code”) and slightly reduces code clarity, although it has no impact on correctness or runtime behavior.
The rest of the function relies only on total_hs and the implicit relation between hs and inis. The unused total_inis appears to be left over from an earlier version of the code or a refactoring.
Solution

Remove the unused local variable total_inis and keep the existing logic unchanged.
Testing

Trivial change. No additional testing.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8372384: Remove unused local variable in MacroAssembler::sha512_update_sha_state on PPC (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28472/head:pull/28472
$ git checkout pull/28472

Update a local copy of the PR:
$ git checkout pull/28472
$ git pull https://git.openjdk.org/jdk.git pull/28472/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28472

View PR using the GUI difftool:
$ git pr show -t 28472

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28472.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Nov 24, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2025

Hi @wb-ly878512, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user wb-ly878512" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Nov 24, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8372384: Remove unused local variable in MacroAssembler::sha512_updat… 8372384: Remove unused local variable in MacroAssembler::sha512_update_sha_state on PPC Nov 24, 2025
@openjdk
Copy link

openjdk bot commented Nov 24, 2025

@wb-ly878512 The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@wb-ly878512
Copy link
Author

wb-ly878512 commented Nov 24, 2025

The contribution is made on behalf of Alibaba.

@wb-ly878512
Copy link
Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Nov 24, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot [email protected] oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status

Development

Successfully merging this pull request may close these issues.

2 participants