Skip to content

Conversation

@Sorna-Sarathi
Copy link
Contributor

@Sorna-Sarathi Sorna-Sarathi commented Nov 24, 2025

Adds missing Classpath Exception statements
JDK Issue: JDK-8372399


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28474/head:pull/28474
$ git checkout pull/28474

Update a local copy of the PR:
$ git checkout pull/28474
$ git pull https://git.openjdk.org/jdk.git pull/28474/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28474

View PR using the GUI difftool:
$ git pr show -t 28474

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28474.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2025

👋 Welcome back ssarathi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 24, 2025

@Sorna-Sarathi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372399: Add missing CPE statements

Reviewed-by: asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@alexeysemenyukoracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Nov 24, 2025

@Sorna-Sarathi The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@Sorna-Sarathi Sorna-Sarathi changed the title 8372399: Add missing CPE statements 8372399:Add missing CPE statements Nov 24, 2025
@Sorna-Sarathi Sorna-Sarathi changed the title 8372399:Add missing CPE statements 8372399: Add missing CPE statements Nov 24, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 24, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 24, 2025

Webrevs

@alexeysemenyukoracle
Copy link
Member

Thank you for the fix!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 24, 2025
@Sorna-Sarathi
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 24, 2025
@openjdk
Copy link

openjdk bot commented Nov 24, 2025

@Sorna-Sarathi
Your change (at version df6a1cc) is now ready to be sponsored by a Committer.

@sendaoYan
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 26, 2025

Going to push as commit 7cc584f.
Since your change was applied there have been 32 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 26, 2025
@openjdk openjdk bot closed this Nov 26, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 26, 2025
@openjdk
Copy link

openjdk bot commented Nov 26, 2025

@sendaoYan @Sorna-Sarathi Pushed as commit 7cc584f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs [email protected] integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants