Skip to content

8372376: ZGC: Inaccurate verification of raw nulls in flip promoting pages #28477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

8372376: ZGC: Inaccurate verification of raw nulls in flip promoting pages #28477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/hotspot/share/gc/z/zVerify.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,10 @@ static void z_verify_root_oop_object(zaddress addr, void* p) {

static void z_verify_old_oop(zpointer* p) {
const zpointer o = *p;
assert(o != zpointer::null, "Old should not contain raw null");
if (o == zpointer::null) {
guarantee(ZGeneration::young()->is_phase_mark_complete(), "Only possible when flip promoting");
guarantee(ZHeap::heap()->page(p)->is_allocating(), "Raw nulls only possible in allocating pages");
}
if (!z_is_null_relaxed(o)) {
if (ZPointer::is_mark_good(o)) {
// Even though the pointer is mark good, we can't verify that it should
Expand Down