Skip to content

Conversation

@Harshit470250
Copy link

@Harshit470250 Harshit470250 commented Nov 27, 2025

JDK-8347405 introduced a mergeStores optimisation which requires ReverseBytesS opcode and as it was not implemented for s390 the test case is failing.
I also implemented ReverseBytesUS.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8372641: [s390x] Test failure TestMergeStores.java (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28523/head:pull/28523
$ git checkout pull/28523

Update a local copy of the PR:
$ git checkout pull/28523
$ git pull https://git.openjdk.org/jdk.git pull/28523/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28523

View PR using the GUI difftool:
$ git pr show -t 28523

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28523.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2025

👋 Welcome back Harshit470250! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8372641 8372641: [s390x] Test failure TestMergeStores.java Nov 27, 2025
@openjdk
Copy link

openjdk bot commented Nov 27, 2025

@Harshit470250 The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 27, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 27, 2025

Webrevs

Copy link
Contributor

@mhaessig mhaessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this, @Harshit470250. The new instructions look good to me. I am only unsure about the cost (see comments below).

Harshit470250 and others added 2 commits November 27, 2025 14:11
Review

Co-authored-by: Manuel Hässig <[email protected]>
Co-authored-by: Amit Kumar <[email protected]>
Copy link
Contributor

@mhaessig mhaessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments. This looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants