-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8372641: [s390x] Test failure TestMergeStores.java #28523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back Harshit470250! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@Harshit470250 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
mhaessig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this, @Harshit470250. The new instructions look good to me. I am only unsure about the cost (see comments below).
Review Co-authored-by: Manuel Hässig <[email protected]> Co-authored-by: Amit Kumar <[email protected]>
mhaessig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments. This looks good to me.
JDK-8347405 introduced a mergeStores optimisation which requires ReverseBytesS opcode and as it was not implemented for s390 the test case is failing.
I also implemented ReverseBytesUS.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28523/head:pull/28523$ git checkout pull/28523Update a local copy of the PR:
$ git checkout pull/28523$ git pull https://git.openjdk.org/jdk.git pull/28523/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28523View PR using the GUI difftool:
$ git pr show -t 28523Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28523.diff
Using Webrev
Link to Webrev Comment