8372650: Convert GenericWaitBarrier to use Atomic<T>

[kimbarrett]

Please review this change to GenericWaitBarrier to use Atomic rather than
directly applying AtomicAccess to volatile members.

Testing: mach5 tier1-5

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372650: Convert GenericWaitBarrier to use Atomic<T> (Enhancement - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28527/head:pull/28527
$ git checkout pull/28527

Update a local copy of the PR:
$ git checkout pull/28527
$ git pull https://git.openjdk.org/jdk.git pull/28527/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28527

View PR using the GUI difftool:
$ git pr show -t 28527

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28527.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372650: Convert GenericWaitBarrier to use Atomic<T>

Reviewed-by: shade, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• e071afb: 8351334: [ubsan] memoryReserver.cpp:552:60: runtime error: applying non-zero offset 1073741824 to null pointer
• 78b155b: 8372147: ConnectionFlowControlTest should use HttpResponse.connectionLabel()
• 08c16c3: 8372704: ThreadMXBean.getThreadUserTime may return total time
• ... and 19 more: https://git.openjdk.org/jdk/compare/7cd3d7f157708ebb6ce972b46a1a90379f63d08f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kimbarrett The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (3577ba5e)
• 00: Full (618e1a03)

[shipilev]

Looks right, except one place:

[shipilev]

Does not have to be _acquire, original load is relaxed.

[kimbarrett]

Oops. Will fix.

[shipilev]

Looks fine now, thanks.

[walulyai]

Looks good!

[kimbarrett]

Thanks for reviews @shipilev and @walulyai

[kimbarrett]

/integrate

[openjdk]

Going to push as commit 52568bf.
Since your change was applied there have been 22 commits pushed to the master branch:

• e071afb: 8351334: [ubsan] memoryReserver.cpp:552:60: runtime error: applying non-zero offset 1073741824 to null pointer
• 78b155b: 8372147: ConnectionFlowControlTest should use HttpResponse.connectionLabel()
• 08c16c3: 8372704: ThreadMXBean.getThreadUserTime may return total time
• ... and 19 more: https://git.openjdk.org/jdk/compare/7cd3d7f157708ebb6ce972b46a1a90379f63d08f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kimbarrett Pushed as commit 52568bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.