Skip to content

Conversation

@krk
Copy link

@krk krk commented Nov 27, 2025

It still fails in oracle environment as described in JDK-8371630.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ 8372587 is used in problem lists: [test/jdk/ProblemList.txt]

Issue

  • JDK-8372587: Put jdk/jfr/jvm/TestWaste.java into the ProblemList (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28539/head:pull/28539
$ git checkout pull/28539

Update a local copy of the PR:
$ git checkout pull/28539
$ git pull https://git.openjdk.org/jdk.git pull/28539/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28539

View PR using the GUI difftool:
$ git pr show -t 28539

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28539.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2025

👋 Welcome back krk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 27, 2025

@krk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@krk
Copy link
Author

krk commented Nov 27, 2025

/label hotspot-jfr

@openjdk
Copy link

openjdk bot commented Nov 27, 2025

@krk
The hotspot-jfr label was successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 27, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 27, 2025

Webrevs

@krk
Copy link
Author

krk commented Nov 27, 2025

only failure which is on macOS, seems unrelated:

TEST: gc/shenandoah/compiler/TestClone.java#generational-verify
...
#  Internal Error (/Users/runner/work/jdk/jdk/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp:1356), pid=18315, tid=16899
#  Error: Remembered set violation at init-update-references; object not properly registered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-jfr [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant