-
Notifications
You must be signed in to change notification settings - Fork 224
8350285: Shenandoah: Regression caused by ShenandoahLock under extreme contention #3614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8350285: Shenandoah: Regression caused by ShenandoahLock under extreme contention #3614
Conversation
Hi @dtmhuang, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user dtmhuang" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
/covered |
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
|
Webrevs
|
/approval request for backport of JDK-8350285 Shenandoah: Regression caused by ShenandoahLock under extreme contention Motivation: Without this change, ShenandoahLock has some performance regression Risk: Low. Ran GHA Sanity Checks, and tier 1 and tier 2 tests locally. Patch is clean. Change has been present in tip since February, 2025. |
Backport for ShenandoahLock performance regression issue. The fix involves sleeping for a very short duration every 3 yields, with the number of yields picked through manual testing.
Clean backport, ran GHA sanity checks and locally tested
tier1
,tier2
, andhotspot_gc_shenandoah
.test/jdk/java/nio/channels/FileChannel/directio/DirectIOTest.java
sometimes fails locally, but it also sometimes failed before the backport.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3614/head:pull/3614
$ git checkout pull/3614
Update a local copy of the PR:
$ git checkout pull/3614
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3614/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3614
View PR using the GUI difftool:
$ git pr show -t 3614
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3614.diff
Using Webrev
Link to Webrev Comment