-
Notifications
You must be signed in to change notification settings - Fork 227
8358538: Update GHA Windows runner to 2025 #3617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
Looks like this one is failing in the same way as 21u |
9db046d
to
fc11ccf
Compare
@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
/issue add JDK-8360042 |
@shipilev |
/approval 8358538 request Same reason as for 21u |
I also need an (R)eview for the series of clean backports... |
Push approval granted. Here goes. /integrate |
Going to push as commit cd08601.
Your commit was automatically rebased without conflicts. |
Fixes GHA. Current Windows runners are already in brown-out stage, and will be decommissioned by the end of the month. So we need to get it into update repos soon.
Additional testing:
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3617/head:pull/3617
$ git checkout pull/3617
Update a local copy of the PR:
$ git checkout pull/3617
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3617/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3617
View PR using the GUI difftool:
$ git pr show -t 3617
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3617.diff
Using Webrev
Link to Webrev Comment