Skip to content

8358538: Update GHA Windows runner to 2025 #3617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jun 5, 2025

Fixes GHA. Current Windows runners are already in brown-out stage, and will be decommissioned by the end of the month. So we need to get it into update repos soon.

Additional testing:

  • GHA

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8358538 needs maintainer approval
  • JDK-8360042 needs maintainer approval

Issues

  • JDK-8358538: Update GHA Windows runner to 2025 (Bug - P4 - Approved)
  • JDK-8360042: GHA: Bump MSVC to 14.44 (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3617/head:pull/3617
$ git checkout pull/3617

Update a local copy of the PR:
$ git checkout pull/3617
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3617/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3617

View PR using the GUI difftool:
$ git pr show -t 3617

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3617.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 5, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 5, 2025

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358538: Update GHA Windows runner to 2025
8360042: GHA: Bump MSVC to 14.44

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b787ff6def08a050b690b60e4a0ceb3aec2b73c8 8358538: Update GHA Windows runner to 2025 Jun 5, 2025
@openjdk
Copy link

openjdk bot commented Jun 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 5, 2025
@openjdk
Copy link

openjdk bot commented Jun 5, 2025

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 5, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 5, 2025

Webrevs

@gnu-andrew
Copy link
Member

Looks like this one is failing in the same way as 21u

@shipilev shipilev force-pushed the JDK-8358538-gha-windows2025 branch from 9db046d to fc11ccf Compare June 23, 2025 17:19
@openjdk
Copy link

openjdk bot commented Jun 23, 2025

@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Jun 23, 2025
@shipilev
Copy link
Member Author

/issue add JDK-8360042

@openjdk
Copy link

openjdk bot commented Jun 23, 2025

@shipilev
Adding additional issue to issue list: 8360042: GHA: Bump MSVC to 14.44.

@shipilev
Copy link
Member Author

/approval 8358538 request Same reason as for 21u
/approval 8360042 request Same reason as for 21u

@openjdk
Copy link

openjdk bot commented Jun 23, 2025

@shipilev
8358538: The approval request has been created successfully.

@openjdk
Copy link

openjdk bot commented Jun 23, 2025

@shipilev
8360042: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Jun 23, 2025
@shipilev
Copy link
Member Author

shipilev commented Jun 25, 2025

I also need an (R)eview for the series of clean backports...

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 25, 2025
@shipilev
Copy link
Member Author

Push approval granted. Here goes.

/integrate

@openjdk
Copy link

openjdk bot commented Jun 25, 2025

Going to push as commit cd08601.
Since your change was applied there have been 5 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 25, 2025
@openjdk openjdk bot closed this Jun 25, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jun 25, 2025
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jun 25, 2025
@openjdk
Copy link

openjdk bot commented Jun 25, 2025

@shipilev Pushed as commit cd08601.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants