Skip to content

7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream #3667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toddjonker
Copy link
Contributor

@toddjonker toddjonker commented Jun 19, 2025

This is a clean backport of d3f3011, originally authored by @archiecobbs and reviewed by @jaikiran

The corresponding backport for JDK21 is openjdk/jdk21u-dev#1897

Testing:

  • New regression test fails without the fix, passes with it
  • linux-x86_64-server-release: headless tiers 1-3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8340729 to be approved
  • JDK-7036144 needs maintainer approval

Issues

  • JDK-7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream (Bug - P4 - Requested)
  • JDK-8340729: GZIPInputStream readTrailer uses faulty available() test for end-of-stream (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3667/head:pull/3667
$ git checkout pull/3667

Update a local copy of the PR:
$ git checkout pull/3667
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3667/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3667

View PR using the GUI difftool:
$ git pr show -t 3667

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3667.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2025

👋 Welcome back toddjonker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d3f3011d56267360d65841da3550eca79cf1575b 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream Jun 19, 2025
@openjdk
Copy link

openjdk bot commented Jun 19, 2025

This backport pull request has now been updated with issue from the original commit.

@toddjonker toddjonker marked this pull request as ready for review July 2, 2025 17:21
@openjdk
Copy link

openjdk bot commented Jul 2, 2025

⚠️ @toddjonker This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 2, 2025
@toddjonker
Copy link
Contributor Author

/approval request This issue has been observed causing data loss.

@toddjonker
Copy link
Contributor Author

/integrate auto

@openjdk
Copy link

openjdk bot commented Jul 2, 2025

@toddjonker
7036144: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 2, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 2, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant