8301255: Http2Connection may send too many GOAWAY frames

[GoeLin]

I backport this for parity with 17.0.17-oracle.

Omitted copyrights as files already have younger ones.

Resolved two chunks in Http2Connection because later change
"8328286: Enhance HTTP client" was already backported.

In shutdown(Throwable) that change added line
cause.compareAndSet(null, t);
messing up the context.
Also, it removed the line
if (initialCause == null) this.cause = t;
this change intends to edit, so I omitted this edit.

In protocolError(int, String) "8328286: Enhance HTTP client" added some
code that needs to go into the if() added by this change.
Resolved. so that it is the same as in 21.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8301255 needs maintainer approval

Issue

• JDK-8301255: Http2Connection may send too many GOAWAY frames (Bug - P4 - Approved)

Reviewers

• Ralf Schmelter (@schmelter-sap - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3686/head:pull/3686
$ git checkout pull/3686

Update a local copy of the PR:
$ git checkout pull/3686
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3686/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3686

View PR using the GUI difftool:
$ git pr show -t 3686

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3686.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301255: Http2Connection may send too many GOAWAY frames

Reviewed-by: rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• f40b56e: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass
• c5f41eb: 8350483: AArch64: turn on signum intrinsics by default on Ampere CPUs
• a897ee8: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (c1c2e424)

[GoeLin]

GAH failure: download failed. Unrelated.
jdk-17.0.17/fastdebug/lib/modules: truncated gzip input

[schmelter-sap]

Looks good.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

Thanks for the review!

[GoeLin]

/integrate

[openjdk]

Going to push as commit 6317de8.
Since your change was applied there have been 5 commits pushed to the master branch:

• faaa691: 8301004: httpclient: Add more debug to HttpResponseInputStream
• 0756108: 8297424: java/net/httpclient/AsyncExecutorShutdown.java fails in AssertionError due to misplaced assert
• f40b56e: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass
• ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/2dc6bac7bf3c39ad35b2db2c70d839130de036b9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 6317de8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.