Skip to content

8302635: Race condition in HttpBodySubscriberWrapper when cancelling request #3690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 30, 2025

I backport this for parity with 17.0.17-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8302635 needs maintainer approval

Issue

  • JDK-8302635: Race condition in HttpBodySubscriberWrapper when cancelling request (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3690/head:pull/3690
$ git checkout pull/3690

Update a local copy of the PR:
$ git checkout pull/3690
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3690/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3690

View PR using the GUI difftool:
$ git pr show -t 3690

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3690.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 30, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 30, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302635: Race condition in HttpBodySubscriberWrapper when cancelling request

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport edf238b65e441a1d626f3a4ba06170badd05ca7c 8302635: Race condition in HttpBodySubscriberWrapper when cancelling request Jun 30, 2025
@openjdk
Copy link

openjdk bot commented Jun 30, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 30, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 30, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 30, 2025

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jul 2, 2025

GHA failure: build hangs, unrelated.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jul 2, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Jul 3, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jul 3, 2025

Going to push as commit c53cae6.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 3, 2025
@openjdk openjdk bot closed this Jul 3, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 3, 2025
@openjdk
Copy link

openjdk bot commented Jul 3, 2025

@GoeLin Pushed as commit c53cae6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant