8353950: Clipboard interaction on Windows is unstable

[matthiasblaesing]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8353950 needs maintainer approval
• JDK-8332271 needs maintainer approval

Issues

• JDK-8353950: Clipboard interaction on Windows is unstable (Bug - P4 - Approved)
• JDK-8332271: Reading data from the clipboard from multiple threads crashes the JVM (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3746/head:pull/3746
$ git checkout pull/3746

Update a local copy of the PR:
$ git checkout pull/3746
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3746/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3746

View PR using the GUI difftool:
$ git pr show -t 3746

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3746.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mblaesing! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@matthiasblaesing This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353950: Clipboard interaction on Windows is unstable
8332271: Reading data from the clipboard from multiple threads crashes the JVM

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 74c0296: Merge
• 3758e58: 8365375: Method SU3.setAcceleratorSelectionForeground assigns to acceleratorForeground
• 2ed2edb: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel
• ... and 10 more: https://git.openjdk.org/jdk17u-dev/compare/3625d2ce6a4a56920a256390292a1aa450a4e070...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issues from the original commit.

[openjdk]

⚠️ @matthiasblaesing This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e07bd4fc)
• 00: Full (74a909a8)

[matthiasblaesing]

Same testing as for master, jdk25 backport and jdk21 backport were applied:

• Tests from test/jdk/java/awt/Clipboard were successfully run with fastdebug and release configuration. It was verified, that the new test fails before the change and succeeds afterwards.
• Application level test already done with the original change were repeated and verified

[matthiasblaesing]

/approval JDK-8353950 request

[matthiasblaesing]

/approval JDK-8332271 request

[openjdk]

@matthiasblaesing
JDK-8353950: The approval request has been created successfully.

[openjdk]

@matthiasblaesing
JDK-8332271: The approval request has been created successfully.

[GoeLin]

Hi @matthiasblaesing
thanks for the comment about the testing.
Still, please give appropriate fix request comment, see https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix
Also, I'd like to defer this to the next update.

[matthiasblaesing]

/approval JDK-8353950 request NetBeans used to have a work around to "fix" flaky clipboard access. That "fix" was installed using a security manager. The removal of the security manager support from the JDK forced the NetBeans IDE to take an alternative approach. It currently relies on an agent to break into the JDK classes and hack the implementation to synchronize access to the clipboard code, which works, but is a really ugly approach. The right way is to actually fix the clipboard which is done in this change. Users indicated, that an unstable clipboard interaction is not acceptable.

[matthiasblaesing]

/approval JDK-8332271 request Crashing the VM with regular AWT calls is not acceptable and needs to be fixed.

[openjdk]

@matthiasblaesing
JDK-8353950: The approval request has been updated successfully.

[openjdk]

@matthiasblaesing
JDK-8332271: The approval request has been updated successfully.

[matthiasblaesing]

@GoeLin you write:

Also, I'd like to defer this to the next update.

I'm not sure how to judge that. Reading the timetable on the 17u site last release was two days ago, so could you clarify?
In general I'm not generally opposed to deferral, I'd just like to know that this issue is finally completely gone at some point.

[GoeLin]

Hi @matthiasblaesing ,
currently we submit for the October release. I would approve it for the January release. Development of that starts September 3rd.

[matthiasblaesing]

@GoeLin thanks for the clarification. For NetBeans this make the change unneeded, as by that time JDK 25 will have been released and thus JDK 17 will drop out from the supported JDK range (supported range is current LTS - 1).

However from the opensource contribution perspective, I think it is ok and also gives a realistic planning timeframe to drop the workaround needed because of a broken JDK.

[bridgekeeper]

@matthiasblaesing This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[matthiasblaesing]

/keepalive

[openjdk]

@matthiasblaesing The pull request is being re-evaluated and the inactivity timeout has been reset.

[GoeLin]

Hi @matthiasblaesing
please merge head and make sure the tests pass.

[matthiasblaesing]

@GoeLin thank you for the heads-up. I merged master, rebuild my setup and pushed the update here.

The new unittest still works and the manual test (NB27 copy-pasting to notepad in a loop) still fails with Amazon Corretto 17.0.16.8.1 and works with the built from this branch.