8367901: Calendar.roll(hour, 24) returns wrong result

[rm-gh-8]

Backporting JDK-8367901: Calendar.roll(hour, 24) returns wrong result. Fixes the roll implementation and adds a new test. Ran GHA Sanity Checks (passed) and new test (passed). The merge conflict was just the copyright header which was updated to the newer one. The new test needed to be updated for compatibility with the older JDK.

Key changes for the new test:

1. @FieldSource → @MethodSource: Changed to method source and created hours() method
2. List.of() → Arrays.asList(): Used Arrays.asList for better compatibility
3. .toList() → .collect(Collectors.toList()): Explicit collection instead of toList()
4. var → explicit types: Replaced var declarations with explicit types
5. Enhanced for loops: Used traditional for-each syntax instead of var

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8367901 needs maintainer approval

Issue

• JDK-8367901: Calendar.roll(hour, 24) returns wrong result (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4167/head:pull/4167
$ git checkout pull/4167

Update a local copy of the PR:
$ git checkout pull/4167
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4167/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4167

View PR using the GUI difftool:
$ git pr show -t 4167

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4167.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (7be27ce4)

[rm-gh-8]

/approval request for backport of JDK-8367901: Calendar.roll(hour, 24) returns wrong result

Updated the new test in the backport to be compatible with JDK 17. Ran the new and related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(All Passed) - make test TEST=test/jdk/java/util/Calendar

Results are attached.
linux-aarch64-specific-test.log
linux-x64-specific-test.log
macos-aarch64-specific-test.log
windows-x64-specific-test.log

[openjdk]

@rm-gh-8
8367901: The approval request has been created successfully.