-
Notifications
You must be signed in to change notification settings - Fork 232
8347300: Don't exclude the "PATH" var from the environment when running app launchers in jpackage tests #4173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/integrate |
Backport for the same reasons as for the backport to 21, now to 17.
Based of the change pushed in 21.
I had to resolve CfgFile.java, the code in 17 looks slightly different.
Further I omitted the changes to LauncherAsServiceVerifier.java
because that file is not in 17.
I had to do some further adaptions to make the changes compile.
The code uses some methods only in 21 (List.reversed() and List.getFirst()).
I replaced these by plain coding.
In 21, record Comm has been moved out of TKIT, this is needed now in 17,
too.
Find these changes in the second commit.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4173/head:pull/4173$ git checkout pull/4173Update a local copy of the PR:
$ git checkout pull/4173$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4173/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4173View PR using the GUI difftool:
$ git pr show -t 4173Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4173.diff
Using Webrev
Link to Webrev Comment