Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 12, 2025

Backport for the same reasons as for the backport to 21, now to 17.
Based of the change pushed in 21.

I had to resolve CfgFile.java, the code in 17 looks slightly different.
Further I omitted the changes to LauncherAsServiceVerifier.java
because that file is not in 17.

I had to do some further adaptions to make the changes compile.
The code uses some methods only in 21 (List.reversed() and List.getFirst()).
I replaced these by plain coding.
In 21, record Comm has been moved out of TKIT, this is needed now in 17,
too.
Find these changes in the second commit.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8347300 needs maintainer approval

Issue

  • JDK-8347300: Don't exclude the "PATH" var from the environment when running app launchers in jpackage tests (Enhancement - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4173/head:pull/4173
$ git checkout pull/4173

Update a local copy of the PR:
$ git checkout pull/4173
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4173/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4173

View PR using the GUI difftool:
$ git pr show -t 4173

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4173.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347300: Don't exclude the "PATH" var from the environment when running app launchers in jpackage tests

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • c9f4ceb: 8310915: Typo in aarch64.ad: "envcodings"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 8374d1f6fff541bef426b668978c31186405089b 8347300: Don't exclude the "PATH" var from the environment when running app launchers in jpackage tests Nov 12, 2025
@openjdk
Copy link

openjdk bot commented Nov 12, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Nov 12, 2025
@GoeLin GoeLin marked this pull request as ready for review November 13, 2025 07:15
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 13, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Nov 13, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

Going to push as commit 22fef0a.
Since your change was applied there has been 1 commit pushed to the master branch:

  • c9f4ceb: 8310915: Typo in aarch64.ad: "envcodings"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 13, 2025
@openjdk openjdk bot closed this Nov 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 13, 2025
@openjdk
Copy link

openjdk bot commented Nov 13, 2025

@GoeLin Pushed as commit 22fef0a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8347300 branch November 13, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants