-
Notifications
You must be signed in to change notification settings - Fork 232
8290499: new File(parent, "/") breaks normalization – creates File with slash at the end #4175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8290499: New File(parent, "/") breaks normalization – creates File with slash at the end. Ran the updated and related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64: (All Passed) - make test TEST=test/jdk/java/io/File Results are attached. |
|
Hi @rm-gh-8 |
|
Risk Mitigation: Potential Risk: Impact Areas: |
Backporting JDK-8290499: New File(parent, "/") breaks normalization – creates File with slash at the end. Fixes the file separator logic and updates a test. Ran GHA Sanity Checks (passed), and related file tests (passed). Patch is clean.
Progress
Warning
8290499: new File(parent, "/") breaks normalization – creates File with slash at the endIssue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4175/head:pull/4175$ git checkout pull/4175Update a local copy of the PR:
$ git checkout pull/4175$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4175/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4175View PR using the GUI difftool:
$ git pr show -t 4175Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4175.diff
Using Webrev
Link to Webrev Comment