8292043: Incorrect decoding near EOF for stateful decoders like UTF-16

[rm-gh-8]

Backporting JDK-8292043: Incorrect decoding near EOF for stateful decoders like UTF-16. Fixes incorrect state handling with EOF in StreamDecoder. There's a reset() call to the decoder seeing the EOF before the last decode() operation to handle the state correctly. Removing the call should not affect other cases because reset() is issued down the execution.

Also adds a new test. Ran GHA Sanity Checks (passed) and new test (passed). Patch is clean.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8292043 needs maintainer approval

Issue

• JDK-8292043: Incorrect decoding near EOF for stateful decoders like UTF-16 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4177/head:pull/4177
$ git checkout pull/4177

Update a local copy of the PR:
$ git checkout pull/4177
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4177/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4177

View PR using the GUI difftool:
$ git pr show -t 4177

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4177.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292043: Incorrect decoding near EOF for stateful decoders like UTF-16

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• a0082e6: 8366844: Update and automate MouseDraggedOriginatedByScrollBarTest.java
• d7f888c: 8366229: runtime/Thread/TooSmallStackSize.java runs with all collectors
• 2635b9d: 8333569: jpackage tests must run app launchers with retries on Linux only
• ... and 17 more: https://git.openjdk.org/jdk17u-dev/compare/3bddec8f8150efb1e022c4a3943777adda96f1ef...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[rm-gh-8]

/approval request for backport of JDK-8292043: Incorrect decoding near EOF for stateful decoders like UTF-16.

Ran the updated and related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(All Passed) - make test TEST=test/jdk/java/io/InputStreamReader

Results are attached.
linux-aarch64-specific-test.log
linux-x64-specific-test.log
macos-aarch64-specific-test.log
windows-x64-specific-test.log

[openjdk]

@rm-gh-8
8292043: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (62bbf4c3)

[rm-gh-8]

/integrate

[openjdk]

@rm-gh-8
Your change (at version 62bbf4c) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 4272f8c.
Since your change was applied there have been 22 commits pushed to the master branch:

• e9c962c: 8308633: Increase precision of timestamps in g1 log
• fd86129: 8317264: Pattern.Bound has static fields that should be static final.
• a0082e6: 8366844: Update and automate MouseDraggedOriginatedByScrollBarTest.java
• ... and 19 more: https://git.openjdk.org/jdk17u-dev/compare/3bddec8f8150efb1e022c4a3943777adda96f1ef...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @rm-gh-8 Pushed as commit 4272f8c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.