8351484: Race condition in max stats in MonitorList::add

[fandreuz]

Unclean backport of JDK-8351484. Fixes a race condition in MonitorList::add. The new test does not pass on master. Conflicts were related to the import statements in the test file.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8351484 needs maintainer approval

Issue

• JDK-8351484: Race condition in max stats in MonitorList::add (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1778/head:pull/1778
$ git checkout pull/1778

Update a local copy of the PR:
$ git checkout pull/1778
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1778/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1778

View PR using the GUI difftool:
$ git pr show -t 1778

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1778.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fandreuz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @fandreuz This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (9407d9c3)

[fandreuz]

/label remove clean

[openjdk]

@fandreuz
The label clean is not a valid label.
These labels are valid:

[fandreuz]

/approval Fixes JDK-8351484. Solves a race condition in MonitorList. Conflicts only happened in test code.

[openjdk]

@fandreuz usage: /approval [<id>] (request|cancel) [<text>]

[fandreuz]

/approval request Fixes JDK-8351484. Solves a race condition in MonitorList. Conflicts only happened in test code.

[openjdk]

@fandreuz
8351484: The approval request has been created successfully.

[phohensee]

"new test does not pass" ??

[fandreuz]

@phohensee The new test does not pass on the master branch of this repository, because the race condition is still there. But it's fixed by this backport. I simply tested that the race condition also happens in jdk21, and not only in the repository where it was originally found.

[phohensee]

Thanks for clearing that up for me.

[bridgekeeper]

@fandreuz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@fandreuz This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.