Skip to content

8351484: Race condition in max stats in MonitorList::add #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

fandreuz
Copy link
Contributor

@fandreuz fandreuz commented May 14, 2025

Unclean backport of JDK-8351484. Fixes a race condition in MonitorList::add. The new test does not pass on master. Conflicts were related to the import statements in the test file.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8351484 needs maintainer approval

Issue

  • JDK-8351484: Race condition in max stats in MonitorList::add (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1778/head:pull/1778
$ git checkout pull/1778

Update a local copy of the PR:
$ git checkout pull/1778
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1778/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1778

View PR using the GUI difftool:
$ git pr show -t 1778

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1778.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 14, 2025

👋 Welcome back fandreuz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 14, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 1d147ccb4cfcb1da23664ac941e56ac542a7ac61 8351484: Race condition in max stats in MonitorList::add May 14, 2025
@openjdk
Copy link

openjdk bot commented May 14, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels May 14, 2025
@openjdk
Copy link

openjdk bot commented May 14, 2025

⚠️ @fandreuz This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 14, 2025
@mlbridge
Copy link

mlbridge bot commented May 14, 2025

Webrevs

@fandreuz
Copy link
Contributor Author

/label remove clean

@openjdk
Copy link

openjdk bot commented May 14, 2025

@fandreuz
The label clean is not a valid label.
These labels are valid:

@fandreuz
Copy link
Contributor Author

/approval Fixes JDK-8351484. Solves a race condition in MonitorList. Conflicts only happened in test code.

@openjdk
Copy link

openjdk bot commented May 14, 2025

@fandreuz usage: /approval [<id>] (request|cancel) [<text>]

@fandreuz
Copy link
Contributor Author

/approval request Fixes JDK-8351484. Solves a race condition in MonitorList. Conflicts only happened in test code.

@openjdk
Copy link

openjdk bot commented May 14, 2025

@fandreuz
8351484: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label May 14, 2025
@phohensee
Copy link
Member

"new test does not pass" ??

@fandreuz
Copy link
Contributor Author

@phohensee The new test does not pass on the master branch of this repository, because the race condition is still there. But it's fixed by this backport. I simply tested that the race condition also happens in jdk21, and not only in the repository where it was originally found.

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label May 15, 2025
@phohensee
Copy link
Member

Thanks for clearing that up for me.

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 13, 2025

@fandreuz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2025

@fandreuz This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants