-
Notifications
You must be signed in to change notification settings - Fork 131
8351484: Race condition in max stats in MonitorList::add #1778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewed-by: pchilanomate, zgu
👋 Welcome back fandreuz! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/label remove clean |
@fandreuz |
/approval Fixes JDK-8351484. Solves a race condition in |
@fandreuz usage: |
/approval request Fixes JDK-8351484. Solves a race condition in MonitorList. Conflicts only happened in test code. |
"new test does not pass" ?? |
@phohensee The new test does not pass on the |
Thanks for clearing that up for me. |
@fandreuz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
@fandreuz This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Unclean backport of JDK-8351484. Fixes a race condition in
MonitorList::add
. The new test does not pass onmaster
. Conflicts were related to the import statements in the test file.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1778/head:pull/1778
$ git checkout pull/1778
Update a local copy of the PR:
$ git checkout pull/1778
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1778/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1778
View PR using the GUI difftool:
$ git pr show -t 1778
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1778.diff
Using Webrev
Link to Webrev Comment