8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class()

[TimPushkin]

The original change cleaned up code of static CDS. I am backporting it as a dependency of JDK-8315130 which I am backporting next (#1835): without this change the backport JDK-8315130 would need to include some parts of this change and would also leave some code unused.

Resolved conflicts:

• src/hotspot/share/cds/unregisteredClasses.cpp: bug fix JDK-8343416 is missing in this version but the backported change itself incorporates the bug fix (to verify I checked that the backport makes the test added in JDK-8343416 pass, but I did not include that test in this PR)
• src/hotspot/share/cds/classListParser.*pp: constant pool resolution was added there in JDK 23/24 as part of Project Layden (JDK-8293980, JDK-8332176) — this required only insignificant changes to the backport
• The rest of the conflicts were trivial (caused by renaming, neighboring code removal, copyright year updates)

Testing besides the CI (performed on macos/arm64): runtime/cds, test added in JDK-8343416 (not included in the backport since that is a separate change).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8348240 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() (Enhancement - P4 - Requested)

Reviewers

• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1834/head:pull/1834
$ git checkout pull/1834

Update a local copy of the PR:
$ git checkout pull/1834
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1834/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1834

View PR using the GUI difftool:
$ git pr show -t 1834

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1834.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tpushkin! A progress list of the required criteria for merging this PR into pr/1833 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (f8bf196c)
• 01: Full - Incremental (ec2af255)
• 00: Full (ec2af255)

[bridgekeeper]

@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[TimPushkin]

/touch

Waiting for review

[openjdk]

@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout app-cds-bug-2
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[TimPushkin]

@iklam Thank you for reviewing the main backport #1835, could you please also review this dependency of it?

[iklam]

@TimPushkin could you get JDK 21u maintainer approval first?

[TimPushkin]

@iklam I am new to backporting, but the order is to first get a review and only then request a maintainer approval. Or do you mean for #1835? I figured, it is better to request approvals for both changes at the same time, since I won't be able to merge that without this one anyway.

[iklam]

I compared the diff of this PR vs the original diff. The changes seem to be functional identical.

[openjdk]

⚠️ @TimPushkin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[iklam]

@iklam I am new to backporting, but the order is to first get a review and only then request a maintainer approval. Or do you mean for #1835? I figured, it is better to request approvals for both changes at the same time, since I won't be able to merge that without this one anyway.

Thanks for the explanation about maintainer approval. I have reviewed this PR and it seems to be functionally correct. It's up to the maintainer to decide whether this backport should be accepted into JDK 21u.

[TimPushkin]

Thank you for the review!

[TimPushkin]

/approval request This backport of static CDS' code cleanup is a pre-requisite for backporting JDK-8315130.

Tests passed: tier1 (via GitHub CI), runtime/cds (locally on macos/arm64).

[openjdk]

@TimPushkin
8348240: The approval request has been created successfully.