8334756: javac crashed on call to non-existent generic method with explicit annotated type arg

[satyenme]

Backporting JDK-8334756: javac crashed on call to non-existent generic method with explicit annotated type arg. Adjusts code to avoid a ClassCastException in javac while compiling a non-existent method annotated with type annotations. Rather than encouraging users to file a JBS issue, directly identify the problematic annotations. Ran GHA Sanity Checks, local Tier 1 and 2, and new test directly. Patch is clean.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8334756 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8334756: javac crashed on call to non-existent generic method with explicit annotated type arg

Issue

• JDK-8334756: javac crashed on call to non-existent generic method with explicit annotated type arg (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1859/head:pull/1859
$ git checkout pull/1859

Update a local copy of the PR:
$ git checkout pull/1859
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1859/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1859

View PR using the GUI difftool:
$ git pr show -t 1859

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1859.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (a0d5cc8b)

[satyenme]

/approval request for backport of JDK-8334756: javac crashed on call to non-existent generic method with explicit annotated type arg

Motivation: Without this change a ClassCastException exception will be thrown when using javac to compile a non-existent method annotated with type annotations - the exception message will direct users to "Please file a bug against the Java compiler via the Java bug reporting page (https://bugreport.java.com) after checking the Bug Database (https://bugs.java.com) for duplicates". With this backport, rather than encouraging users to file a JBS issue, will directly identify the problematic annotations.

Risk: Low. Ran GHA Sanity Checks, local Tier 1 and 2, and new test directly. Patch is clean. Change has been present in tip since December, 2024.

[openjdk]

@satyenme
8334756: The approval request has been created successfully.

[bridgekeeper]

@satyenme This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!