Skip to content

8311220: Optimization for StringLatin UpperLower #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wkia
Copy link

@wkia wkia commented Jul 17, 2025

This is backport of "JDK-8311220 Optimization for StringLatin UpperLower"

It seems good to have it backported as I see improvements even locally on my i7-12700H (benchmarks command line was taken from original PR):

sh make/devkit/createJMHBundle.sh
bash configure --with-jmh=build/jmh/jars
make test TEST="micro:java.lang.StringUpperLower.*"

----- Baseline JDK21
Benchmark                      Mode  Cnt   Score   Error  Units
StringUpperLower.lowerToLower  avgt   15  24.146 ± 0.216  ns/op
StringUpperLower.lowerToUpper  avgt   15  43.720 ± 2.689  ns/op
StringUpperLower.mixedToLower  avgt   15  27.335 ± 1.120  ns/op
StringUpperLower.mixedToUpper  avgt   15  43.239 ± 3.731  ns/op
StringUpperLower.upperToLower  avgt   15  28.310 ± 1.557  ns/op
StringUpperLower.upperToUpper  avgt   15  35.032 ± 1.840  ns/op

----- Backported
Benchmark                      Mode  Cnt   Score   Error  Units
StringUpperLower.lowerToLower  avgt   15  13.890 ± 0.786  ns/op
StringUpperLower.lowerToUpper  avgt   15  38.636 ± 2.103  ns/op
StringUpperLower.mixedToLower  avgt   15  28.087 ± 1.639  ns/op
StringUpperLower.mixedToUpper  avgt   15  33.970 ± 0.502  ns/op
StringUpperLower.upperToLower  avgt   15  28.394 ± 1.443  ns/op
StringUpperLower.upperToUpper  avgt   15  17.347 ± 0.578  ns/op

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8311220 needs maintainer approval

Issue

  • JDK-8311220: Optimization for StringLatin UpperLower (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1988/head:pull/1988
$ git checkout pull/1988

Update a local copy of the PR:
$ git checkout pull/1988
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1988/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1988

View PR using the GUI difftool:
$ git pr show -t 1988

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1988.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 17, 2025

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport f09b7af6851c725b0fc4d63832b52e17c4d24836 8311220: Optimization for StringLatin UpperLower Jul 17, 2025
@openjdk
Copy link

openjdk bot commented Jul 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 17, 2025
@openjdk
Copy link

openjdk bot commented Jul 17, 2025

⚠️ @wkia This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 17, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 17, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 18, 2025

@wkia
8311220: The approval request has been created successfully.

@wkia
Copy link
Author

wkia commented Jul 18, 2025

/approval request This is backport of JDK-8311220. Clean backport. All checks are passed. It'd be good to backport this as I see improvements even locally.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jul 18, 2025
@openjdk
Copy link

openjdk bot commented Jul 18, 2025

@wkia
8311220: The approval request was already up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant