Skip to content
This repository was archived by the owner on Jul 15, 2025. It is now read-only.

8358066: Non-ascii package names gives compilation error "import requires canonical name" #232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

archiecobbs
Copy link

@archiecobbs archiecobbs commented Jun 17, 2025

This pull request contains a backport of commit 09ec4de7 from the openjdk/jdk repository.

This fixes a bug which causes some import statements containing non-ASCII class names to fail when the compiler is configured to use one of the older UTF-8 based Name table implementations (e.g., via -XDuseUnsharedTable=true).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8358066 needs maintainer approval

Issue

  • JDK-8358066: Non-ascii package names gives compilation error "import requires canonical name" (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/232/head:pull/232
$ git checkout pull/232

Update a local copy of the PR:
$ git checkout pull/232
$ git pull https://git.openjdk.org/jdk24u.git pull/232/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 232

View PR using the GUI difftool:
$ git pr show -t 232

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/232.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2025

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 09ec4de74d495560ffb9ec529df7ec818c1d617c 8358066: Non-ascii package names gives compilation error "import requires canonical name" Jun 17, 2025
@openjdk
Copy link

openjdk bot commented Jun 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 17, 2025

⚠️ @archiecobbs This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 17, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2025

Webrevs

@archiecobbs
Copy link
Author

/approval request This unbreaks builds for people compiling files that make heavy use of non-ASCII characters

@openjdk
Copy link

openjdk bot commented Jun 17, 2025

@archiecobbs
8358066: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jun 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant