8372753: jpackage ignores --file-associations option with predefined app image #395
+41
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix handling of the
--file-associationsoption when bundling from the predefined app image. Add relevant tests.Progress
Warning
8372753: jpackage ignores --file-associations option with predefined app imageIssue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/395/head:pull/395$ git checkout pull/395Update a local copy of the PR:
$ git checkout pull/395$ git pull https://git.openjdk.org/jdk25u.git pull/395/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 395View PR using the GUI difftool:
$ git pr show -t 395Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/395.diff
Using Webrev
Link to Webrev Comment