Skip to content

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Nov 29, 2025

Fix handling of the --file-associations option when bundling from the predefined app image. Add relevant tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8372753 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8372753: jpackage ignores --file-associations option with predefined app image

Issue

  • JDK-8372753: jpackage ignores --file-associations option with predefined app image (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/395/head:pull/395
$ git checkout pull/395

Update a local copy of the PR:
$ git checkout pull/395
$ git pull https://git.openjdk.org/jdk25u.git pull/395/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 395

View PR using the GUI difftool:
$ git pr show -t 395

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/395.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2025

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 29, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 29, 2025

@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2025

Webrevs

@alexeysemenyukoracle alexeysemenyukoracle deleted the JDK-8372753 branch November 29, 2025 00:58
@alexeysemenyukoracle alexeysemenyukoracle restored the JDK-8372753 branch November 29, 2025 00:58
@alexeysemenyukoracle alexeysemenyukoracle marked this pull request as draft November 29, 2025 01:01
@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 29, 2025
@alexeysemenyukoracle alexeysemenyukoracle marked this pull request as ready for review November 29, 2025 01:05
@alexeysemenyukoracle alexeysemenyukoracle changed the title 8372753: jpackage ignres --file-associations option with predefined app image 8372753: jpackage ignores --file-associations option with predefined app image Nov 29, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant