Skip to content

8056283: @ignore tools/javac/defaultMethods/Assertions.java until JDK-8047675 is fixed #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jul 15, 2025

Hi all,

I want to backport JDK-8047675 to jdk8u-dev, but I found that this PR is the prefixed PR to backport JDK-8047675 to jdk8u-dev.

This PR only add @ignore derictive to disable the test. Test-fix only, no risk.


Progress

  • JDK-8056283 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8056283: @ignore tools/javac/defaultMethods/Assertions.java until JDK-8047675 is fixed (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/669/head:pull/669
$ git checkout pull/669

Update a local copy of the PR:
$ git checkout pull/669
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/669/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 669

View PR using the GUI difftool:
$ git pr show -t 669

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/669.diff

Using Webrev

Link to Webrev Comment

@sendaoYan
Copy link
Member Author

/approval request This is clean backport and it's prefix backport of JDK-8047675. Test-fix only, no risk.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 15, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d66c4567eea47bd74037b49acbd85d71a2cf239a 8056283: @ignore tools/javac/defaultMethods/Assertions.java until JDK-8047675 is fixed Jul 15, 2025
@openjdk
Copy link

openjdk bot commented Jul 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 15, 2025
@openjdk
Copy link

openjdk bot commented Jul 15, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 15, 2025
@openjdk
Copy link

openjdk bot commented Jul 15, 2025

@sendaoYan
8056283: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jul 15, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 15, 2025

Webrevs

@sendaoYan
Copy link
Member Author

GHA report several test failures:

  1. Several 'jdk/security_infra' job fails, it's known CA test issue, it's unrelated to this PR.
  2. 'Linux x86 (hotspot/tier1)' job report test gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java trigger jvm crash in 'CompactibleFreeListSpace::block_size(HeapWord const*)',it's known issue which recorded by JDK-8303159, it's unrelated ti this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants