Skip to content

Conversation

@tkiriyama
Copy link
Member

@tkiriyama tkiriyama commented Oct 21, 2025

Hi All,

I would like to backport this bug fix (JDK-8212768) done in jdk13 to jdk8. It is basically a clean backport, but only the copyright of awt_InputMethod.cpp and awt_Component.cpp is not updated because the current source is newer.

The following fixes are resolved.

Issue A: Cannot display surrogate pair character on Windows floating IME window for passive component
It has been reproduced using the test program (SwingSet2) in a specific environment and verified that this fix resolves it.

Issue B: Control Windows IME status using InputSubset and UnicodeBlock for CJK countries
It has been reproduced using the test program (ImSubsetsTest.java) in a specific environment and verified that this fix resolves it.

Issue C: Check pre-edit string availability for Windows Chinese IME
It probably won't happen again in the new environment. I have verified that the behavior of the test program (IMFTestA.java) remains unchanged after this fix.

JTREG tests were executed using the -a option (automatic tests only) for the test suites java/awt/Component and java/awt/InputMethods. No failures were found.

The changes implemented in JDK-8212678 alone are not sufficient to fully resolve IME-related issues. To ensure a complete fix, the changes from JDK-8258805 must also be integrated.
I plan to create a separate pull request.

Thank you.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8212678 needs maintainer approval

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/706/head:pull/706
$ git checkout pull/706

Update a local copy of the PR:
$ git checkout pull/706
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/706/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 706

View PR using the GUI difftool:
$ git pr show -t 706

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/706.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2025

👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 21, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 21, 2025

Webrevs

@tkiriyama tkiriyama changed the title 8212678: Windows IME related patch Backport 60613c5fbc2554cbbf09d79804de276b9c2d786c Oct 22, 2025
@openjdk openjdk bot changed the title Backport 60613c5fbc2554cbbf09d79804de276b9c2d786c 8212678: Windows IME related patch Oct 22, 2025
@openjdk
Copy link

openjdk bot commented Oct 22, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant