8212678: Windows IME related patch #706
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi All,
I would like to backport this bug fix (JDK-8212768) done in jdk13 to jdk8. It is basically a clean backport, but only the copyright of awt_InputMethod.cpp and awt_Component.cpp is not updated because the current source is newer.
The following fixes are resolved.
Issue A: Cannot display surrogate pair character on Windows floating IME window for passive component
It has been reproduced using the test program (SwingSet2) in a specific environment and verified that this fix resolves it.
Issue B: Control Windows IME status using InputSubset and UnicodeBlock for CJK countries
It has been reproduced using the test program (ImSubsetsTest.java) in a specific environment and verified that this fix resolves it.
Issue C: Check pre-edit string availability for Windows Chinese IME
It probably won't happen again in the new environment. I have verified that the behavior of the test program (IMFTestA.java) remains unchanged after this fix.
JTREG tests were executed using the
-aoption (automatic tests only) for the test suites java/awt/Component and java/awt/InputMethods. No failures were found.The changes implemented in JDK-8212678 alone are not sufficient to fully resolve IME-related issues. To ensure a complete fix, the changes from JDK-8258805 must also be integrated.
I plan to create a separate pull request.
Thank you.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/706/head:pull/706$ git checkout pull/706Update a local copy of the PR:
$ git checkout pull/706$ git pull https://git.openjdk.org/jdk8u-dev.git pull/706/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 706View PR using the GUI difftool:
$ git pr show -t 706Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/706.diff
Using Webrev
Link to Webrev Comment