Skip to content

8355415: RichTextArea: NPE in VFlow::scrollCaretToVisible #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Apr 23, 2025

Fixed an NPE that should only happen in a headless test environment.

This is a follow-up for #1677


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8355415: RichTextArea: NPE in VFlow::scrollCaretToVisible (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1793/head:pull/1793
$ git checkout pull/1793

Update a local copy of the PR:
$ git checkout pull/1793
$ git pull https://git.openjdk.org/jfx.git pull/1793/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1793

View PR using the GUI difftool:
$ git pr show -t 1793

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1793.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 23, 2025

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 23, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@andy-goryachev-oracle andy-goryachev-oracle marked this pull request as ready for review April 24, 2025 18:56
@openjdk openjdk bot added the rfr Ready for review label Apr 24, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 24, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Ready for review
Development

Successfully merging this pull request may close these issues.

1 participant