Skip to content

Updated JavaDoc header for Rotate.java #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dtonhofer
Copy link

@dtonhofer dtonhofer commented May 31, 2025

The current JavaDoc header erroneously says the example given (a rotation around Z in 2D) is generic. The header is otherwise hard to read, I tried to ameliorate it.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1818/head:pull/1818
$ git checkout pull/1818

Update a local copy of the PR:
$ git checkout pull/1818
$ git pull https://git.openjdk.org/jfx.git pull/1818/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1818

View PR using the GUI difftool:
$ git pr show -t 1818

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1818.diff

The current JavaDoc header erroneously says the example given (a rotation around Z in 2D) is generic. The header is otherwise hard to read, I tried to ameliorate it.
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label May 31, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented May 31, 2025

Hi @dtonhofer, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user dtonhofer" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented May 31, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2025

@dtonhofer This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oca Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

1 participant