Skip to content

8362091: Window title bar should reflect scene color scheme #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mstr2
Copy link
Collaborator

@mstr2 mstr2 commented Jul 13, 2025

Currently, the color scheme of a system-decorated stage is as follows:

  • On Windows, the title bar is always light (even if the OS color scheme is dark).
  • On macOS and Linux, the title bar is light or dark depending on the OS color scheme.

The expected behavior is that the title bar matches the color scheme of the Scene.
If an application doesn't specify a color scheme, the title bar color should match the OS color scheme.

This PR fixes the behavior for Windows and macOS, but not for Linux (there's no good way to do that).
Depending on how you look at it, this is either a bug fix or an enhancement.

/reviewers 2


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8362091: Window title bar should reflect scene color scheme (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1845/head:pull/1845
$ git checkout pull/1845

Update a local copy of the PR:
$ git checkout pull/1845
$ git pull https://git.openjdk.org/jfx.git pull/1845/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1845

View PR using the GUI difftool:
$ git pr show -t 1845

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1845.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 13, 2025

👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Ready for review label Jul 13, 2025
@openjdk
Copy link

openjdk bot commented Jul 13, 2025

@mstr2
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@mlbridge
Copy link

mlbridge bot commented Jul 13, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Ready for review
Development

Successfully merging this pull request may close these issues.

1 participant