-
Notifications
You must be signed in to change notification settings - Fork 542
8368478: RichTextArea: add IME support #1938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8368478: RichTextArea: add IME support #1938
Conversation
|
👋 Welcome back angorya! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@andy-goryachev-oracle |
|
@lukostyra Can you also review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I tested this on Windows with rich editor demo and using both polish and spanish IME shortcuts - all work fine after this change
I wrote this comment on Windows and something shorted in my brain when I was typing this. I meant on Linux, Ubuntu 24.04.2 :) |
|
On Mac and Linux dead key sequences are delivered as InputMethodEvents. When typing ü using dead keys the user previews the diacritic mark (¨) as composed text and then the final character (ü) is delivered as committed text. |
|
Does it show any underline/dotted shapes? How do you type ü in German layout (on macOS)? edit: Please disregard, I see it! Typing + or shift-+ (using the US keyboard) shows an IME composition shape. |
|
I usually test using a US keyboard and typing Option+e for ´ or Option+u for ¨ or Option+n for ˜ |

Adds Input Method Editor (IME) support to
RichTextArea/CodeArea.Tested on macOS and Windows 11 with Japanese and Chinese (pinyin) input methods.
Please test this on Linux, even though there is no platform-specific code in this PR (should work the same way it does in
TextArea/TextField)For testing, one can use the updated Monkey Tester
https://github.com/andy-goryachev-oracle/MonkeyTest
(optionally enable IME events in stdout with Logging -> IME Monitor)
/reviewers 2
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1938/head:pull/1938$ git checkout pull/1938Update a local copy of the PR:
$ git checkout pull/1938$ git pull https://git.openjdk.org/jfx.git pull/1938/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1938View PR using the GUI difftool:
$ git pr show -t 1938Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1938.diff
Using Webrev
Link to Webrev Comment