Skip to content

Conversation

@andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Oct 24, 2025

Fixes the cursor over the content area vs other parts of the RichTextArea and CodeArea.

Root cause: styling wrong thing in modena.css.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8364777: RichTextArea: cursor over scrollbar (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1947/head:pull/1947
$ git checkout pull/1947

Update a local copy of the PR:
$ git checkout pull/1947
$ git pull https://git.openjdk.org/jfx.git pull/1947/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1947

View PR using the GUI difftool:
$ git pr show -t 1947

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1947.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2025

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364777: RichTextArea: cursor over scrollbar

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 478e1ad: 8370632: Additional libxslt 1.1.43 fixes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@andy-goryachev-oracle andy-goryachev-oracle marked this pull request as ready for review October 24, 2025 20:16
@openjdk openjdk bot added the rfr Ready for review label Oct 24, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2025

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One reviewer is sufficient for this simple fix.

@openjdk openjdk bot added the ready Ready to be integrated label Oct 29, 2025
@andy-goryachev-oracle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 29, 2025

Going to push as commit 200b01f.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 478e1ad: 8370632: Additional libxslt 1.1.43 fixes

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 29, 2025
@openjdk openjdk bot closed this Oct 29, 2025
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Oct 29, 2025
@openjdk
Copy link

openjdk bot commented Oct 29, 2025

@andy-goryachev-oracle Pushed as commit 200b01f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andy-goryachev-oracle andy-goryachev-oracle deleted the 8364777.cursor branch October 29, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants