8439: ArithmeticException thrown when plotting event count histogram with maxDuration set to 0

[aymane-harmaz]

When plotting event count histogram and all event durations are set to 0, the duration range will be evaluated to 0, leading to an ArithmeticException (divid by 0), which stops JMC from plotting that histogram.

This can be shown on the attached screenshot, where only the percentile table is shown and the histogram chart is missing

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JMC-8439: ArithmeticException thrown when plotting event count histogram with maxDuration set to 0 (Bug - P3)

Reviewers

• Marcus Hirt (@thegreystone - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/675/head:pull/675
$ git checkout pull/675

Update a local copy of the PR:
$ git checkout pull/675
$ git pull https://git.openjdk.org/jmc.git pull/675/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 675

View PR using the GUI difftool:
$ git pr show -t 675

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/675.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aymane-harmaz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aymane-harmaz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8439: ArithmeticException thrown when plotting event count histogram with maxDuration set to 0

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 01: Full - Incremental (9e8221a5)
• 00: Full (469f134e)

[thegreystone]

Nice catch. To avoid FP equality and unit conversion surprises, please compare against zero using nanoseconds:
maxDuration.longValueIn(UnitLookup.NANOSECOND) == 0L

[aymane-harmaz]

Thanks for the insight.
I used clampedLongValueIn as the only critical case here is equality with 0L, and this way we don’t need to handle conversion exceptions explicitly

[thegreystone]

Good to go!

[aymane-harmaz]

Thanks for the review.

/integrate

[openjdk]

@aymane-harmaz
Your change (at version 9e8221a) is now ready to be sponsored by a Committer.

[thegreystone]

/sponsor

[openjdk]

Going to push as commit 58ca84a.

[openjdk]

@thegreystone @aymane-harmaz Pushed as commit 58ca84a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.