7904105: intermittent test failure in CleanupDirTests.agentvm.conc

[vpa1977]

jtharness does not synchronize calls to Observer. Synchronized keyword needs to be added when processing shared state.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• CODETOOLS-7904105: intermittent test failure in CleanupDirTests.agentvm.conc (Bug - P4)

Reviewers

• Christian Stein (@sormuras - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/297/head:pull/297
$ git checkout pull/297

Update a local copy of the PR:
$ git checkout pull/297
$ git pull https://git.openjdk.org/jtreg.git pull/297/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 297

View PR using the GUI difftool:
$ git pr show -t 297

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/297.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vpetko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vpa1977 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7904105: intermittent test failure in CleanupDirTests.agentvm.conc

Reviewed-by: cstein

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

• a6a32dd: 7904110: IDEA plugin: Update plugin for new message format
• da877fc: 7904106: TestNativePath: intermittent test failures due to different test targets using same work dir
• 34ccc66: 7904094: Release jtreg 8.1
• ... and 44 more: https://git.openjdk.org/jtreg/compare/a3a514cc46c3fe17a2d0969878f0b630e9825c60...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sormuras) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (e346596f)

[jaikiran]

Hello Vladimir, we have seen intermittent failure in this test too, but i haven't had a chance to look deeper.

TestStats deals with counts in several different methods, so I'm not completely sure the proposed change is enough or the best way to address this. It may be that the code in TestStats itself might need to be addressed in some manner.

[vpa1977]

Hello Vladimir, we have seen intermittent failure in this test too, but i haven't had a chance to look deeper.

TestStats deals with counts in several different methods, so I'm not completely sure the proposed change is enough or the best way to address this. It may be that the code in TestStats itself might need to be addressed in some manner.

Hi,

I have tried using atomics in TestStats and the implementation looked ugly / required a lot of refactoring.

jtreg only updates counts using jtharness Observer callbacks. We already use synchonzied keyword in Observer callbacks[1] as the TestRunner spawns multiple threads if we specify concurrency > 1. I have used Intellij Idea to find all inheritors of BasicObserver and added synchronization.

Maybe the better way would be to synchronize in jtharness itself to avoid doing it in the client code?
Hmm, this is probably impossible unless we want to make a breaking change and remove notifier field from Script class.

[1]

jtreg/src/share/classes/com/sun/javatest/regtest/report/ElapsedTimeHandler.java

Line 64 in 34ccc66

public synchronized void startingTest(TestResult tr) {

[bridgekeeper]

@vpa1977 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[vpa1977]

/touch

[openjdk]

@vpa1977 The pull request is being re-evaluated and the inactivity timeout has been reset.

[sormuras]

This change looks good-enough for the time being.

As @jaikiran said, there's potential to address this in a more fundamental way, but adding those three synchronized modifiers a) doesn't hurt, b) seems to address the flaky test issue, and c) doesn't prevent future improvements.