Skip to content

Conversation

@erikj79
Copy link
Member

@erikj79 erikj79 commented Oct 29, 2025

This is an awesome PR description.


Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/playground.git pull/246/head:pull/246
$ git checkout pull/246

Update a local copy of the PR:
$ git checkout pull/246
$ git pull https://git.openjdk.org/playground.git pull/246/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 246

View PR using the GUI difftool:
$ git pr show -t 246

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/playground/pull/246.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 29, 2025

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 29, 2025

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Test SKARA-2610

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Oct 29, 2025

@erikj79 The following labels will be automatically applied to this pull request:

  • build
  • client
  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Oct 29, 2025

Webrevs

@erikj79 erikj79 closed this Oct 29, 2025
@erikj79 erikj79 reopened this Oct 29, 2025
@erikj79 erikj79 closed this Oct 29, 2025
@erikj79 erikj79 reopened this Oct 29, 2025
@erikj79 erikj79 closed this Oct 29, 2025
@erikj79 erikj79 reopened this Oct 29, 2025
@erikj79 erikj79 closed this Oct 29, 2025
@erikj79 erikj79 reopened this Oct 29, 2025
@erikj79 erikj79 closed this Oct 29, 2025
@erikj79 erikj79 reopened this Oct 29, 2025
@erikj79 erikj79 closed this Oct 30, 2025
@erikj79 erikj79 reopened this Oct 30, 2025
@erikj79 erikj79 closed this Oct 30, 2025
@erikj79 erikj79 reopened this Oct 30, 2025
@erikj79 erikj79 closed this Oct 30, 2025
@erikj79 erikj79 reopened this Oct 30, 2025
@erikj79 erikj79 closed this Oct 31, 2025
@erikj79 erikj79 reopened this Oct 31, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2025

@erikj79 This pull request has been inactive for more than 7 days and will be automatically closed if another 7 days passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants