Skip to content

Adding flattening of strict final fields #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: lworld
Choose a base branch
from

Conversation

fparain
Copy link
Collaborator

@fparain fparain commented Mar 24, 2025

Strict final instance fields are not subject to concurrent writes during a read access, so they can be flattened even if they are nullable and bigger than 64 bits. The NULLABLE_NON_ATOMIC_FLAT layout is added for this particular case.


Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1407/head:pull/1407
$ git checkout pull/1407

Update a local copy of the PR:
$ git checkout pull/1407
$ git pull https://git.openjdk.org/valhalla.git pull/1407/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1407

View PR using the GUI difftool:
$ git pr show -t 1407

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1407.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 24, 2025

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 24, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant