Skip to content

8354366: [lworld] VirtualObjectDebugInfoTest fails after merging jdk-25+16 #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: lworld
Choose a base branch
from

Conversation

MrSimms
Copy link
Member

@MrSimms MrSimms commented Apr 14, 2025

Partially undo JDK-8350892, specifically field sorting


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8354366: [lworld] VirtualObjectDebugInfoTest fails after merging jdk-25+16 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1430/head:pull/1430
$ git checkout pull/1430

Update a local copy of the PR:
$ git checkout pull/1430
$ git pull https://git.openjdk.org/valhalla.git pull/1430/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1430

View PR using the GUI difftool:
$ git pr show -t 1430

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1430.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 14, 2025

👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 14, 2025

@MrSimms This change is no longer ready for integration - check the PR body for details.

@MrSimms MrSimms marked this pull request as draft April 14, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant