Skip to content

8361218: [lworld] Remove LockingMode from test #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Jul 1, 2025

See issue - the LockingMode flags will be removed in mainline, so adjusting this test.
Tested with the test.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8361218: [lworld] Remove LockingMode from test (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1495/head:pull/1495
$ git checkout pull/1495

Update a local copy of the PR:
$ git checkout pull/1495
$ git pull https://git.openjdk.org/valhalla.git pull/1495/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1495

View PR using the GUI difftool:
$ git pr show -t 1495

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1495.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 1, 2025

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 1, 2025

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361218: [lworld] Remove LockingMode from test

Reviewed-by: matsaave

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the lworld branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 1, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 1, 2025

Webrevs

@coleenp coleenp changed the title [lworld] Remove LockingMode from test 8361218: [lworld] Remove LockingMode from test Jul 2, 2025
Copy link
Contributor

@matias9927 matias9927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and seems trivial. Thanks!

@coleenp
Copy link
Contributor Author

coleenp commented Jul 3, 2025

Thanks Matias.

@coleenp
Copy link
Contributor Author

coleenp commented Jul 3, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jul 3, 2025

Going to push as commit cbe19cd.
Since your change was applied there have been 5 commits pushed to the lworld branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 3, 2025
@openjdk openjdk bot closed this Jul 3, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 3, 2025
@openjdk
Copy link

openjdk bot commented Jul 3, 2025

@coleenp Pushed as commit cbe19cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the lockingmode branch July 3, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants