8366668: [lworld] Follow-up work from the array metadata re-work

[TobiHartmann]

This is a follow-up from JDK-8366705 resolving a large number of ToDos in the implementation and tests.

There are a few remaining ToDos that I'll address with JDK-8370341 because this change is getting too large and is blocking other work.

Best regards,
Tobias

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8366668: [lworld] Follow-up work from the array metadata re-work (Enhancement - P2)

Reviewers

• Frederic Parain (@fparain - Committer) ⚠️ Review applies to a48b2ae0

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1672/head:pull/1672
$ git checkout pull/1672

Update a local copy of the PR:
$ git checkout pull/1672
$ git pull https://git.openjdk.org/valhalla.git pull/1672/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1672

View PR using the GUI difftool:
$ git pr show -t 1672

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1672.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366668: [lworld] Follow-up work from the array metadata re-work

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[fparain]

This call modifies the next_refined_array_klass pointer, which makes test on line 395 operating on an obsolete value. Not a semantic issue considering the case being handled, but not a good coding practice.
Could you move this code inside the block where the MultiArray_lock is already owned?

[TobiHartmann]

Thanks for the review Fred! I pushed an updated version, please let me know what you think.

[fparain]

Runtime changes look good to me.

[TobiHartmann]

Thanks again for the review Fred!

[openjdk]

@TobiHartmann this pull request can not be integrated into lworld due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8366668
git fetch https://git.openjdk.org/valhalla.git lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push

[mlbridge]

Webrevs

• 00: Full (a62f3890)

[TobiHartmann]

/integrate

[openjdk]

Going to push as commit 74fc77f.

[openjdk]

@TobiHartmann Pushed as commit 74fc77f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.