-
Notifications
You must be signed in to change notification settings - Fork 125
8369921: [lworld] Remove caches of primitive wrapper classes #1685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: lworld
Are you sure you want to change the base?
8369921: [lworld] Remove caches of primitive wrapper classes #1685
Conversation
Disable use of wrapper cached values when --enable-preview Add javadoc descriptions for enable-preview.
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into |
@RogerRiggs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
No tests need to be updated; |
The tests use |
@IntrinsicCandidate | ||
@DeserializeConstructor | ||
public static Long valueOf(long l) { | ||
final int offset = 128; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend moving this into the preview feature block too.
@DeserializeConstructor | ||
public static Short valueOf(short s) { | ||
final int offset = 128; | ||
int sAsInt = s; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same remark, I recommend moving this into the preview feature check block.
Double and Float already do new, so they are fine. Should we update Boolean.valueOf to return |
Disable use of wrapper cached values when --enable-preview and add javadoc descriptions for enable-preview.
The wrapper classes are Byte, Short, Character, Integer, and Long.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1685/head:pull/1685
$ git checkout pull/1685
Update a local copy of the PR:
$ git checkout pull/1685
$ git pull https://git.openjdk.org/valhalla.git pull/1685/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1685
View PR using the GUI difftool:
$ git pr show -t 1685
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1685.diff
Using Webrev
Link to Webrev Comment