feat: add agents session#2110
Open
benoitf wants to merge 3 commits into
Open
Conversation
benoitf
requested review from
bmahabirbu and
fbricon
and removed request for
a team
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
|
Found the term Completed a little bit confusing as user might understand they cannot interact anymore with them |
Contributor
|
Also got some errors: |
Contributor
Author
it's the term of the mockup... |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Pinging @slemeur then :) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
|
I think to get started with, we go with "completed". later on, the idea is probably more about indicating which sessions are "running", which ones are "idle". but for the end user, it's more about "which one needs my attention". |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
✅ Action performedComments resolved and changes approved. |
This comment was marked as outdated.
This comment was marked as outdated.
jeffmaury
reviewed
Jun 29, 2026
jeffmaury
left a comment
jeffmaury
left a comment
Contributor
There was a problem hiding this comment.
Seems to me that store acpSandboxes is a duplicate of the existing allOpenshellSandboxes
Rename kaiden.label to ai.openkaiden.kaiden.agent
Contributor
📝 WalkthroughWalkthroughAdds end-to-end ACP session support: new public types, main-process session orchestration, IPC and preload bridge wiring, renderer navigation/store integration, and ACP session list/detail UI. ChangesACP Sessions End-to-End Implementation
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
rebased and using current changes |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
MarsKubeX
reviewed
Jun 30, 2026
MarsKubeX
left a comment
MarsKubeX
left a comment
Contributor
There was a problem hiding this comment.
I have tested with an openshell workspace with ollama Zen/Big Pickle model. It works good. I see just one issue. When attaching a document, the file content is embedded inline in the JSON-RPC message sent through the PTY. For larger files, this causes a SyntaxError: JSON Parse error: Unterminated string on the agent side because the message gets truncated/split by the PTY transport. Smaller prompts without attachments work fine.
The "+" button in the input toolbar (bottom-right of the prompt area) feels redundant with the "New Session" button in the sidebar header. Having both is confusing. (I don't know if this is a requirement from the mocks)
Contributor
Author
yes I think it's not written in the body of this PR but this is something I have but it seems it's tracked under OpenShell issues. "Relaying long live sessions" also have issues but it's part of OpenShell (and some PRs are trying to address this issue) |
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Contributor
Author
|
@MarsKubeX I removed the + button and rebased into main |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jeffmaury
reviewed
Jul 1, 2026
jeffmaury
left a comment
jeffmaury
left a comment
Contributor
There was a problem hiding this comment.
LGTM but add a couple of timeout while testing agains a local ollama.
Also claude agent does not support acp (no acp metatada) so it should be either prevented or reported (backend error)
Contributor
|
With an openshell sandbox that either has a bad setup (i.e model url is setup but cant be reached ie was testing on 0.074 with opencode big pickle and had an error saying bad request 
maybe we could bubble up the error to the user or say something like error connecting
Also if we notice here in the selection screen 
A nice to have would be the model selection dropdown as well i couldnt get a screen shot so here a tiny video showing off the dropdown! (it seems its not using a kaiden component but could be wrong) Screencast.From.2026-07-02.01-08-59.mp4 |
bmahabirbu
reviewed
Jul 2, 2026
| {#if hasModels} | ||
| <div class="inline-flex items-center gap-1.5 rounded-full border border-[var(--pd-content-divider)] bg-[var(--pd-content-card-bg)] px-2.5 py-0.5"> | ||
| <span class="w-2 h-2 rounded-full bg-[var(--pd-status-connected)] shrink-0"></span> | ||
| <select |
bmahabirbu
reviewed
Jul 2, 2026
| <div class="inline-flex items-center gap-1.5 rounded-full border border-[var(--pd-content-divider)] bg-[var(--pd-content-card-bg)] px-2.5 py-0.5"> | ||
| <span class="w-2 h-2 rounded-full bg-[var(--pd-status-running)] shrink-0"></span> | ||
| <select | ||
| bind:value={selectedModeId} |
bmahabirbu
reviewed
Jul 2, 2026
| {#each selectConfigOptions as configOpt (configOpt.id)} | ||
| <div class="inline-flex items-center gap-1.5 rounded-full border border-[var(--pd-content-divider)] bg-[var(--pd-content-card-bg)] px-2.5 py-0.5" title={configOpt.description ?? configOpt.name}> | ||
| <span class="w-2 h-2 rounded-full bg-[var(--pd-status-connected)] shrink-0"></span> | ||
| <select |
Contributor
There was a problem hiding this comment.
Replace with dropdown but I believe youll need to flatten the options since dropdown doesnt support the optgroup
MarsKubeX
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow to interact with agents using ACP protocol.