Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation and minor usability fixes #204

Merged
merged 7 commits into from
Mar 26, 2025
Merged

Conversation

ipcamit
Copy link
Collaborator

@ipcamit ipcamit commented Mar 20, 2025

Summary

  • Per atom weights and prediction logging for Physics based and DNN
  • Dataset per atom weight from yaml file
  • Renamed KIMDriverGraph to RadialGraph as that is more appropriate
  • Miscellaneous import issues, platform specific issues fixed for final release
  • exposed strategy and accelerator for lightning trainer
  • Complete documentation with instructions to port model to LAMMPS and ASE, and comparison with DUNN

This concludes the development. Currently it supports python 3.9, due to CMake limitations. Post release I can try and fix it with other releases as well (CMake 3.18 is the only version guaranteed to detect CUDA properly, but has hardcoded support for python <= 3.9). Stress tested it on Debian and RHEL like platforms (docker) and Mac M2, to ensure that all possible errors are catalogued.

The documentation can be seen here: https://kliff-v1.readthedocs.io/en/latest/index.html

TODO

  • Advanced documentation about more customized training

  • Tutorial to implement custom trainer

  • Make sure your code is properly formatted. isort and black are used for this purpose. The simplest way is to use pre-commit. See instructions here.

  • Doc strings have been added in the Google docstring format on your code.

  • Type annotations are highly encouraged. Run mypy to type check your code.

  • Tests have been added for any new functionality or bug fixes.

  • All linting and tests pass.

Note that the CI system will run all the above checks. But it will be much more efficient if you already fix most errors prior to submitting the PR.

@ipcamit
Copy link
Collaborator Author

ipcamit commented Mar 25, 2025

@mjwen Can you have a look at it and give comments when possible. Let me know if it too much, I can try splititng it in individual cherrypicks.

@mjwen
Copy link
Collaborator

mjwen commented Mar 25, 2025

@ipcamit Sorry, forgot about this. Will do it soon.

@mjwen mjwen self-requested a review March 26, 2025 13:55
@mjwen
Copy link
Collaborator

mjwen commented Mar 26, 2025

This is fantastic. I don't have further comments. It is just that the CI testing is failing due to ModuleNotFoundError: No module named torch.

Let's merge this, and can you please fix the CI?

@mjwen mjwen merged commit f267427 into openkim:v1 Mar 26, 2025
1 of 4 checks passed
@ipcamit
Copy link
Collaborator Author

ipcamit commented Mar 26, 2025

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants