fix dot problem in merge-rests-engraver#168
Open
chfin wants to merge 1 commit intoopenlilylib:masterfrom
Open
Conversation
The merge-rests-engraver did not merge the dots of several dotted rests resulting in multiple stacked dots on a single merged rest. This commit fixes the issue by removing the dots from all merged rests except one. Since the engraver only merges rests with the same length, it should not matter which rest keeps the dots, so we take the first.
Contributor
|
Thank you for the pull request. |
Contributor
|
I tried this change but it throws an error when used on rests with no dots. Moreover it keeps the wrong dot, i.e., the lower one. |
Contributor
|
The Scheme engraver Merge_rests_engraver by Thomas Morley (Harm), correctly dealing with dotted rests and full-measure rests, is included in LilyPond 2.20.0 (actually it was included before 2.19.83 and was extended to deal with dotted rests in 2.19.83). The dot positioning problem is actually a bug in LilyPond. |
Contributor
...which is apparently already solved in master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merge-rests-engraver did not merge the dots of several dotted rests resulting in multiple stacked dots on a single merged rest (cf. #123).
This commit fixes the issue by removing the dots from all merged rests except one.
Since the engraver only merges rests with the same length, it should not matter which rest keeps the dots, so we take the first.