Figure of Merit implementation #3363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge remote-tracking branch 'origin/stat_testing' into stat_testing
Merge remote-tracking branch 'upstream/develop' into stat_testing
shimwell
reviewed
Mar 27, 2025
shimwell
reviewed
Mar 27, 2025
shimwell
reviewed
Mar 27, 2025
shimwell
reviewed
Mar 27, 2025
shimwell
reviewed
Mar 27, 2025
shimwell
reviewed
Mar 27, 2025
shimwell
reviewed
Mar 27, 2025
shimwell
reviewed
Mar 27, 2025
|
I had a quick skim through the code, congrats on this work, I am keen to see this feature added. |
paulromano
approved these changes
May 2, 2025
There was a problem hiding this comment.
@Grego01-biot I just did a bit of clean up here and I'd say it's ready to go. Thanks again for the PR!
|
@eepeterson let me know if you're good with the changes here now. If so, please approve so we can merge. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new statistical capability in OpenMC: the ability to compute the figure of merit for each tally bin. This could provide the user with more information on how quickly the population variance of a tally bin decreases. This tally reliability indicator is already implemented in MCNP and can be of interest for many users. Indeed, in order to optimize the tally efficiency, the user could run several simulations using different variance reduction techniques and choose the one with the largest FOM.
Fixes # (issue)
At the moment, this functionality is simply a flag defined in the settings of the tally that the user can activate in order to get it for every tally bin. Most of the modifications are made in the Python API since the mean, the variance and the wall time are already available in the statepoint file.
Checklist