Random Ray Geometry Debug Mode Fix #3615
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When run in geometry debug mode (
openmc -g), the Monte Carlo solver will check for any overlapping cells whenever performing a cross section lookup. As the random ray solver doesn't call this function, no overlap checks are ever performed.This PR simply adds the same overlapping check logic after each ray tracing step is performed in the random ray solver.
I have tested this fix on a random ray input deck featuring a cell overlap (thanks @shimwell!) and it works as expected.
Checklist