Bugfixed chain ID assignment in addSolvent (#287) #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How does this approach work for fixing #287? This should assign B-Z if the previous chain ID was A-Y, and otherwise leave the ID as a numeric chain ID.
One comment: I noticed PDBFile and PDBxFile simply use
% 26
to map numeric IDs to the alphabet. Should we warn the user somehow that disparate chains may be assigned matching IDs in these cases?