TRUNK-6243: Add a new runtime property to determine if app is running in development or production mode #4992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgup27
reviewed
Apr 5, 2025
agrpranjal07
reviewed
Apr 6, 2025
There was a problem hiding this comment.
- Have taken default mode to be "development"
- For handling the Stack Trace issue a new method is added formattedStrackTrace with helper methods to show original Stack Trace in dev environment and formatted Stack Trace in production environmet
- Tests are added to check if changes are working in dev and production env or not.
@kgup27 can you throw more light on this |
ibacher
reviewed
Apr 29, 2025
| */ | ||
| public static final String DEVELOPMENT_MODE_RUNTIME_PROPERTY = "development.mode"; | ||
|
|
||
| public static final String DEVELOPMENT_MODE_DEFAULT = "true"; |
There was a problem hiding this comment.
If we were to consider this, the default needs to be false.
There was a problem hiding this comment.
Right, makes sense, let me change, thanks
… in development or production mode
… in development or production mode
IamMujuziMoses
force-pushed
the
TRUNK-6243
branch
from
0b4cfb7 to
df87afd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-6243
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master