AUDIT-54: Implement Administration Events Logging - #57
Open
sudhanshu-raj wants to merge 16 commits into
Open
Conversation
Contributor
Author
|
It's reference here : openmrs/openmrs-core#6384 |
# Conflicts: # api/src/main/resources/liquibase.xml # api/src/main/resources/moduleApplicationContext.xml # omod/src/main/java/org/openmrs/module/auditlogweb/extension/html/AdminList.java # omod/src/main/webapp/localHeader.jsp
Open
5 tasks
…to long for count methods
sudhanshu-raj
marked this pull request as ready for review
August 6, 2026 07:20
Contributor
Author
|
This is now ready for the review though we still need to first merge the core PR but meanwhile can test this in locally by pulling that core branch PR changes, let me know what all I miss and needed to correct @wikumChamith @dkayiwa @ManojLL |
Member
|
@sudhanshu-raj did you get a chance to look at the failing builds? |
Contributor
Author
Main reason for this failure is that we need to merge the core PR for this bcz we publishing the events from there and it needed to get merge there, although this failure is spotless plugin error which is temporary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
This includes auditing the action done by admin, and here in this feature we are adding Module event audit logging, so it's goal is to audit the module events like module load, unload, start and stop. And we are only auditing the action done manually not by the background thread.
Basically this works on when the platform module will publish the module events then this module will listen to that and log in DB. That's why we are also publishing those events from the core in this PR
Issue I worked on
see https://openmrs.atlassian.net/browse/AUDIT-54
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master