(fix) O3-5638: Remove cashier timesheet feature since it's no longer used - #164
Open
solomonfortune wants to merge 5 commits into
Open
(fix) O3-5638: Remove cashier timesheet feature since it's no longer used#164solomonfortune wants to merge 5 commits into
solomonfortune wants to merge 5 commits into
Conversation
Contributor
|
@solomonfortune please look into the failing jobs |
Author
@NethmiRodrigo let me work on that |
5 tasks
Author
|
@NethmiRodrigo @wikumChamith |
Member
Can you resolve the merge conflicts and also take a look at the three new issues Sonar is pointing at? |
dkayiwa
added a commit
that referenced
this pull request
May 21, 2026
The broader timesheet feature is being removed in PR #164 (cashier HR concern, not a billing concern), so indexing timesheets into the querystore would ship a resource type whose source data is about to disappear. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Author
@wikumChamith I have tried to sort these issues out |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the cashier timesheet functionality from the billing module as the feature is no longer in use. The module is now focused purely on billing and payment management.
Closes: O3-5638
Changes Made
Deleted Files
ITimesheetService.java- Timesheet service interfaceTimesheetServiceImpl.java- Timesheet service implementationTimesheet.java- Timesheet domain modelAutoCloseTimesheetsTask.java- Scheduled task for auto-closing timesheetsTimesheetRequiredException.java- Timesheet exception classTimesheetUtil.java- Timesheet utility classTimesheetResource.java- REST resource for timesheetsTimesheetSearchHandler.java- REST search handler for timesheetsTimesheetEntryValidator.java- Timesheet entry validatorCashierController.java- Cashier clock-in/out controllerCashierLogoutFilter.java- Filter that clocked out cashiers on logoutITimesheetServiceTest.java- Timesheet service testsTimesheetTest.xml- Timesheet test datasetModified Files
Cashier.hbm.xml- Removed Timesheet Hibernate mappingmoduleApplicationContext.xml- Removed timesheet Spring bean definitionsconfig.xml- Removed timesheet privileges and global propertiesliquibase.xml- Added changeset to dropcashier_timesheettablemessages.properties- Removed timesheet message keysModuleSettings.java- Removed timesheet-related constants and settingsCashierOptions.java- RemovedtimesheetRequiredfieldCashierSettings.java- Removed timesheet and shift report fieldsPrivilegeConstants.java- Removed timesheet privilege constantsCashierOptionsServiceGpImpl.java- Removed timesheet options loadingBillResource.java- Removed timesheet-based cash point resolutionBillAddEditController.java- Removed timesheet validation on bill creationCashierModuleSettingsController.java- Removed timesheet settings endpointTesting
mvn clean install -DskipTests✅Notes
cashier_timesheetdatabase table will be dropped on module startup via the new Liquibase changeset