(fix) Billing response - #192
Quality Gate failed
Failed conditions
See analysis details on SonarQube Cloud
Annotations
sonarqubecloud / SonarCloud Code Analysis
This block of commented-out lines of code should be removed.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLDTey22SfKEvdXf&open=AZ_IgLDTey22SfKEvdXf&pullRequest=192
sonarqubecloud / SonarCloud Code Analysis
Use "BigDecimal.valueOf" instead.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLDqey22SfKEvdXo&open=AZ_IgLDqey22SfKEvdXo&pullRequest=192
Check failure on line 232 in api/src/main/java/org/openmrs/module/billing/util/Utils.java
sonarqubecloud / SonarCloud Code Analysis
Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLG1ey22SfKEvdXy&open=AZ_IgLG1ey22SfKEvdXy&pullRequest=192
sonarqubecloud / SonarCloud Code Analysis
This block of commented-out lines of code should be removed.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLDTey22SfKEvdXg&open=AZ_IgLDTey22SfKEvdXg&pullRequest=192
sonarqubecloud / SonarCloud Code Analysis
This branch's code block is the same as the block for the branch on line 122.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLHNey22SfKEvdXz&open=AZ_IgLHNey22SfKEvdXz&pullRequest=192
Check warning on line 24 in pom.xml
sonarqubecloud / SonarCloud Code Analysis
Remove this commented out code.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLJzey22SfKEvdX8&open=AZ_IgLJzey22SfKEvdX8&pullRequest=192
sonarqubecloud / SonarCloud Code Analysis
Refactor this method to reduce its Cognitive Complexity from 23 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLDTey22SfKEvdXZ&open=AZ_IgLDTey22SfKEvdXZ&pullRequest=192
Check warning on line 71 in api/src/main/java/org/openmrs/module/billing/util/Utils.java
sonarqubecloud / SonarCloud Code Analysis
Immediately return this expression instead of assigning it to the temporary variable "factory".
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLG1ey22SfKEvdXs&open=AZ_IgLG1ey22SfKEvdXs&pullRequest=192
sonarqubecloud / SonarCloud Code Analysis
Remove this method to simply inherit it.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLHzey22SfKEvdX5&open=AZ_IgLHzey22SfKEvdX5&pullRequest=192
sonarqubecloud / SonarCloud Code Analysis
Make sure this debug feature is deactivated before delivering the code in production.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLFRey22SfKEvdXq&open=AZ_IgLFRey22SfKEvdXq&pullRequest=192
sonarqubecloud / SonarCloud Code Analysis
Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLDTey22SfKEvdXY&open=AZ_IgLDTey22SfKEvdXY&pullRequest=192
sonarqubecloud / SonarCloud Code Analysis
Remove this unused method parameter "bill".
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLHNey22SfKEvdX2&open=AZ_IgLHNey22SfKEvdX2&pullRequest=192
sonarqubecloud / SonarCloud Code Analysis
Refactor this method to reduce its Cognitive Complexity from 32 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLDqey22SfKEvdXj&open=AZ_IgLDqey22SfKEvdXj&pullRequest=192
Check warning on line 88 in api/src/main/java/org/openmrs/module/billing/util/Utils.java
sonarqubecloud / SonarCloud Code Analysis
Use a StringBuilder instead.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLG1ey22SfKEvdXv&open=AZ_IgLG1ey22SfKEvdXv&pullRequest=192
sonarqubecloud / SonarCloud Code Analysis
Remove the unnecessary boolean literal.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLHNey22SfKEvdX0&open=AZ_IgLHNey22SfKEvdX0&pullRequest=192
Check warning on line 369 in api/src/main/java/org/openmrs/module/billing/api/model/Bill.java
sonarqubecloud / SonarCloud Code Analysis
Immediately return this expression instead of assigning it to the temporary variable "dateString".
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgK_Qey22SfKEvdXS&open=AZ_IgK_Qey22SfKEvdXS&pullRequest=192
Check failure on line 228 in api/src/main/java/org/openmrs/module/billing/util/Utils.java
sonarqubecloud / SonarCloud Code Analysis
Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLG1ey22SfKEvdXx&open=AZ_IgLG1ey22SfKEvdXx&pullRequest=192
sonarqubecloud / SonarCloud Code Analysis
Define a constant instead of duplicating this literal "serviceCategory" 3 times.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLHzey22SfKEvdX4&open=AZ_IgLHzey22SfKEvdX4&pullRequest=192
sonarqubecloud / SonarCloud Code Analysis
This block of commented-out lines of code should be removed.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLDTey22SfKEvdXc&open=AZ_IgLDTey22SfKEvdXc&pullRequest=192
sonarqubecloud / SonarCloud Code Analysis
Remove this method to simply inherit it.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLIXey22SfKEvdX7&open=AZ_IgLIXey22SfKEvdX7&pullRequest=192
sonarqubecloud / SonarCloud Code Analysis
Refactor this method to reduce its Cognitive Complexity from 31 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLFRey22SfKEvdXp&open=AZ_IgLFRey22SfKEvdXp&pullRequest=192
Check warning on line 269 in api/src/main/java/org/openmrs/module/billing/api/model/Bill.java
sonarqubecloud / SonarCloud Code Analysis
Use isEmpty() to check whether the collection is empty or not.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgK_Qey22SfKEvdXU&open=AZ_IgK_Qey22SfKEvdXU&pullRequest=192
sonarqubecloud / SonarCloud Code Analysis
This block of commented-out lines of code should be removed.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLDTey22SfKEvdXd&open=AZ_IgLDTey22SfKEvdXd&pullRequest=192
sonarqubecloud / SonarCloud Code Analysis
This block of commented-out lines of code should be removed.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLDTey22SfKEvdXe&open=AZ_IgLDTey22SfKEvdXe&pullRequest=192
sonarqubecloud / SonarCloud Code Analysis
Use isEmpty() to check whether the collection is empty or not.
See more on https://sonarcloud.io/project/issues?id=openmrs_openmrs-module-billing&issues=AZ_IgLDqey22SfKEvdXl&open=AZ_IgLDqey22SfKEvdXl&pullRequest=192