Skip to content

AOM-186: Replace deprecated Boolean constructor in PersonFormController. #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aadvik93 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

AOM-186: Replace deprecated Boolean constructor in PersonFormController. #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d57e365
AOM-182: Replace deprecated Boolean constructor usage in ConceptPropo…
aadvik93 Apr 19, 2026
7fbe7d9
AOM-183: Replace deprecated Boolean constructor in OptionsFormController
aadvik93 Apr 20, 2026
06e21e6
AOM-184: Replace deprecated Boolean constructor in PatientFormController
aadvik93 Apr 25, 2026
64408e5
AOM-186: Replace deprecated Boolean constructor in PersonFormController
aadvik93 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions omod/src/main/java/org/openmrs/web/controller/OptionsFormController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,8 +308,12 @@ protected Object formBackingObject(HttpServletRequest request) throws ServletExc
opts.setDefaultLocation(props.get(OpenmrsConstants.USER_PROPERTY_DEFAULT_LOCATION));
opts.setDefaultLocale(props.get(OpenmrsConstants.USER_PROPERTY_DEFAULT_LOCALE));
opts.setProficientLocales(props.get(OpenmrsConstants.USER_PROPERTY_PROFICIENT_LOCALES));
opts.setShowRetiredMessage(new Boolean(props.get(OpenmrsConstants.USER_PROPERTY_SHOW_RETIRED)));
opts.setVerbose(new Boolean(props.get(OpenmrsConstants.USER_PROPERTY_SHOW_VERBOSE)));
opts.setShowRetiredMessage(Boolean.parseBoolean(
String.valueOf(props.get(OpenmrsConstants.USER_PROPERTY_SHOW_RETIRED))
));
opts.setVerbose(Boolean.parseBoolean(
String.valueOf(props.get(OpenmrsConstants.USER_PROPERTY_SHOW_VERBOSE))
));
opts.setUsername(user.getUsername());

PersonName personName;
Expand Down
4 changes: 2 additions & 2 deletions omod/src/main/java/org/openmrs/web/controller/concept/ConceptProposalListController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ protected Object formBackingObject(HttpServletRequest request) throws ServletExc
if (Context.isAuthenticated()) {
ConceptService cs = Context.getConceptService();
log.debug("tmp value: " + request.getParameter("includeCompleted"));
boolean b = new Boolean(request.getParameter("includeCompleted"));
boolean b = Boolean.parseBoolean(request.getParameter("includeCompleted"));
log.debug("b value: " + b);
cpList = cs.getAllConceptProposals(b);
}
Expand All @@ -64,7 +64,7 @@ protected Object formBackingObject(HttpServletRequest request) throws ServletExc
origText.put(cp.getOriginalText(), matchingProposals);
}

boolean asc = new Boolean("asc".equals(request.getParameter("sortOrder")));
boolean asc = "asc".equals(request.getParameter("sortOrder"));
String sortOn = request.getParameter("sortOn");
if (sortOn == null) {
sortOn = "occurences";
Expand Down
2 changes: 1 addition & 1 deletion omod/src/main/java/org/openmrs/web/controller/patient/PatientFormController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ protected ModelAndView processFormSubmission(HttpServletRequest request, HttpSer
pi.setLocation(ls.getLocation(Integer.valueOf(locs[i])));
}
if (idPrefStatus != null && idPrefStatus.length > i) {
pi.setPreferred(new Boolean(idPrefStatus[i]));
pi.setPreferred(Boolean.parseBoolean(idPrefStatus[i]));
}

BindException piErrors = new BindException(pi, "patientIdentifier");
Expand Down
4 changes: 2 additions & 2 deletions omod/src/main/java/org/openmrs/web/controller/person/PersonFormController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ protected void updatePersonNames(HttpServletRequest request, Person person) {
if (!"".equals(gNames[i])) { //skips invalid and blank address data box
PersonName pn = new PersonName();
if (namePrefStatus != null && namePrefStatus.length > i) {
pn.setPreferred(new Boolean(namePrefStatus[i]));
pn.setPreferred(Boolean.parseBoolean(namePrefStatus[i]));
}
if (gNames.length >= i + 1) {
pn.setGivenName(gNames[i]);
Expand Down Expand Up @@ -645,7 +645,7 @@ protected void updatePersonAddresses(HttpServletRequest request, Person person,
pa.setAddress3(add3s[i]);
}
if (addPrefStatus != null && addPrefStatus.length > i) {
pa.setPreferred(new Boolean(addPrefStatus[i]));
pa.setPreferred(Boolean.parseBoolean(addPrefStatus[i]));
}
if (add6s.length >= i + 1) {
pa.setAddress6(add6s[i]);
Expand Down